Adjust method parameters in noSuchMethod helper stubs

Adjust method parameters in noSuchMethod helper stubs.

If we have code like:

class Cat {
  int eatFood(List<String> foods, [List<String> mixins]) => 0;
  int walk(List<String> places, {Map<String, String> gaits}) => 0;
}

class MockCat extends Mock implements Cat {}

Then the eatFood stub on MockCat cannot just always pass foods and mixins to the new Invocation; it must only pass mixins if mixins was passed originally. This CL fixes that.

Here's a Mockito script that verifies the right behavior (and doesn't work with today's DDC):


import 'package:test/test.dart';

import 'lib/mockito.dart';

class Cat {
  int eatFood(List<String> foods, [List<String> mixins]) => 0;
  int walk(List<String> places, {Map<String, String> gaits}) => 0;
}

class MockCat extends Mock implements Cat {}

void main() {
    print('Should print 1 through 5:');
    dynamic cat = new MockCat();

    when(cat.eatFood(typed/*<List<String>>*/(any))).thenReturn(1);
    when(cat.eatFood(typed/*<List<String>>*/(any), ['tuna'])).thenReturn(2);
    when(cat.eatFood(typed/*<List<String>>*/(any),
            typed/*<List<String>>*/(argThat(hasLength(2)))))
        .thenReturn(3);

    print(cat.eatFood(<String>['mouse']));
    print(cat.eatFood(<String>['mouse'], ['tuna']));
    print(cat.eatFood(<String>['mouse'], ['tuna', 'chicken']));

    when(cat.walk(typed/*<List<String>>*/(any))).thenReturn(4);
    when(cat.walk(typed/*<List<String>>*/(any), gaits: typed/*<Map<String, String>>*/(any, named: 'gaits'))).thenReturn(5);

    print(cat.walk(<String>['window']));
    print(cat.walk(<String>['window'], gaits: {'window': 'quickly'}));
}


Steps to test this file (its a pain):

1. Clone My typed branch of the mockito repo (https://github.com/srawlins/dart-mockito/tree/typed-api).
2. $ pub get
3. Write this file into the root directory of the mockito repo.
4. $ dart --packages=/Users/srawlins/code/dart-dev_compiler/.packages ../dart-dev_compiler/tool/global_compile.dart cat.dart (adjust for your DDC path)
5. $ node out.js

[srawlins, 2016-08-01 18:27:53]

Description was changed from

==========
And the codegen_expected changes


Adjust method parameters in noSuchMethod helper stubs

BUG=
==========

to

==========
Adjust method parameters in noSuchMethod helper stubs.

If we have code like:

class Cat {
  int eatFood(List<String> foods, [List<String> mixins]) => 0;
  int walk(List<String> places, {Map<String, String> gaits}) => 0;
}

class MockCat extends Mock implements Cat {}

Then the eatFood stub on MockCat cannot just always pass foods and mixins to the
new Invocation; it must only pass mixins if mixins was passed originally. This
CL fixes that.

Here's a Mockito script that verifies the right behavior (and doesn't work with
today's DDC):


import 'package:test/test.dart';

import 'lib/mockito.dart';

class Cat {
  int eatFood(List<String> foods, [List<String> mixins]) => 0;
  int walk(List<String> places, {Map<String, String> gaits}) => 0;
}

class MockCat extends Mock implements Cat {}

void main() {
    print('Should print 1 through 5:');
    dynamic cat = new MockCat();

    when(cat.eatFood(typed/*<List<String>>*/(any))).thenReturn(1);
    when(cat.eatFood(typed/*<List<String>>*/(any), ['tuna'])).thenReturn(2);
    when(cat.eatFood(typed/*<List<String>>*/(any),
            typed/*<List<String>>*/(argThat(hasLength(2)))))
        .thenReturn(3);

    print(cat.eatFood(<String>['mouse']));
    print(cat.eatFood(<String>['mouse'], ['tuna']));
    print(cat.eatFood(<String>['mouse'], ['tuna', 'chicken']));

    when(cat.walk(typed/*<List<String>>*/(any))).thenReturn(4);
    when(cat.walk(typed/*<List<String>>*/(any), gaits: typed/*<Map<String,
String>>*/(any, named: 'gaits'))).thenReturn(5);

    print(cat.walk(<String>['window']));
    print(cat.walk(<String>['window'], gaits: {'window': 'quickly'}));
}


Steps to test this file (its a pain):

1. Clone My typed branch of the mockito repo
(https://github.com/srawlins/dart-mockito/tree/typed-api).
2. $ pub get
3. Write this file into the root directory of the mockito repo.
4. $ dart --packages=/Users/srawlins/code/dart-dev_compiler/.packages
../dart-dev_compiler/tool/global_compile.dart cat.dart (adjust for your DDC
path)
5. $ node out.js
==========

[srawlins, 2016-08-01 18:27:53]

srawlins@google.com changed reviewers:
+ jmesserly@google.com, leafp@google.com, vsm@google.com

[srawlins, 2016-08-01 18:30:38]

https://codereview.chromium.org/2202673002/diff/1/lib/src/compiler/code_gener...
File lib/src/compiler/code_generator.dart (right):

https://codereview.chromium.org/2202673002/diff/1/lib/src/compiler/code_gener...
lib/src/compiler/code_generator.dart:1453: 'for (let arg of #) { if (# !== void
0) { #.push(#); } }', [
I think I need help on this line: `arg` needs to be the JS.TemporaryId from line
1448, but if I use:

'for (let # of #) { if (# !== void 0) { #.push(#); } }', and uncomment that arg
on line 1454, then ddc produces this error:

Error in MiniJsParser:
for (let # of #) { if (# !== void 0) { #.push(#); } }
         ^
         Expected ALPHA

#0      MiniJsParser.error (package:dev_compiler/src/js_ast/builder.dart:730:5)
#1      MiniJsParser.expectCategory
(package:dev_compiler/src/js_ast/builder.dart:693:30)
...

Any ideas?

[Jennifer Messerly, 2016-08-01 19:14:53]

Thanks for sending this! Hugely appreciate putting this together along with the
epic comment :). I may be able to fix this in a simple way, let me take a shot.

[srawlins, 2016-08-01 21:13:11]

On 2016/08/01 19:14:53, John Messerly wrote:
> Thanks for sending this! Hugely appreciate putting this together along with
the
> epic comment :). I may be able to fix this in a simple way, let me take a
shot.

Sounds fine to me!