Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 2202643002: GN: only include headers in echo_headers.py (Closed)

Created:
4 years, 4 months ago by mtklein_C
Modified:
4 years, 4 months ago
Reviewers:
jcgregorio
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

GN: only include headers in echo_headers.py This keeps things like VIM .swp files out of skia.h. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2202643002 Committed: https://skia.googlesource.com/skia/+/6be452c80072b5ce4011126a27471ceaec72cfcb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M gn/echo_headers.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
mtklein_C
4 years, 4 months ago (2016-08-01 17:06:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2202643002/1
4 years, 4 months ago (2016-08-01 17:06:57 UTC) #5
jcgregorio
lgtm
4 years, 4 months ago (2016-08-01 17:16:30 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-01 17:39:13 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/6be452c80072b5ce4011126a27471ceaec72cfcb

Powered by Google App Engine
This is Rietveld 408576698