Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 2202633002: [heap] Drop filler objects on marking deque. (Closed)

Created:
4 years, 4 months ago by Hannes Payer (out of office)
Modified:
4 years, 4 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Drop filler objects on marking deque. BUG= Committed: https://crrev.com/9005b5845a0ce13bf6f8ffdf0fdac35fe62a2269 Cr-Commit-Position: refs/heads/master@{#38220}

Patch Set 1 #

Total comments: 4

Patch Set 2 : explicit flag check #

Patch Set 3 : change dcheck order #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -31 lines) Patch
M src/heap/incremental-marking.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/heap/incremental-marking.cc View 1 2 3 chunks +12 lines, -30 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
Hannes Payer (out of office)
https://codereview.chromium.org/2202633002/diff/1/src/heap/incremental-marking.cc File src/heap/incremental-marking.cc (right): https://codereview.chromium.org/2202633002/diff/1/src/heap/incremental-marking.cc#newcode902 src/heap/incremental-marking.cc:902: if (obj->IsFiller()) { If you think that checking the ...
4 years, 4 months ago (2016-08-01 16:43:54 UTC) #4
ulan
https://codereview.chromium.org/2202633002/diff/1/src/heap/incremental-marking.cc File src/heap/incremental-marking.cc (right): https://codereview.chromium.org/2202633002/diff/1/src/heap/incremental-marking.cc#newcode897 src/heap/incremental-marking.cc:897: (bytes_processed < bytes_to_process || completion)) { I think it ...
4 years, 4 months ago (2016-08-01 16:49:43 UTC) #5
ulan
lgtm
4 years, 4 months ago (2016-08-01 16:54:53 UTC) #8
Hannes Payer (out of office)
https://codereview.chromium.org/2202633002/diff/1/src/heap/incremental-marking.cc File src/heap/incremental-marking.cc (right): https://codereview.chromium.org/2202633002/diff/1/src/heap/incremental-marking.cc#newcode897 src/heap/incremental-marking.cc:897: (bytes_processed < bytes_to_process || completion)) { On 2016/08/01 16:49:43, ...
4 years, 4 months ago (2016-08-01 17:11:39 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2202633002/40001
4 years, 4 months ago (2016-08-01 19:03:53 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-01 19:28:04 UTC) #15
commit-bot: I haz the power
4 years, 4 months ago (2016-08-01 19:29:29 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/9005b5845a0ce13bf6f8ffdf0fdac35fe62a2269
Cr-Commit-Position: refs/heads/master@{#38220}

Powered by Google App Engine
This is Rietveld 408576698