Issue 220263003: [DevTools] Migrate device emulation to WebDeviceEmulationParams.

Issue 220263003: [DevTools] Migrate device emulation to WebDeviceEmulationParams. (Closed)

Created:
6 years, 8 months ago by dgozman

Modified:
6 years, 8 months ago

Reviewers:
jochen (gone - plz use gerrit), pfeldman

CC:
chromium-reviews, vsevik, jam, yurys, paulirish+reviews_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

[DevTools] Migrate device emulation to WebDeviceEmulationParams. BUG=327641 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261394

Patch Set 4 : rebase #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+70 lines, -81 lines)			Patch
M	content/renderer/devtools/devtools_agent.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	content/renderer/devtools/devtools_agent.cc	View	1 2	2 chunks	+15 lines, -2 lines	0 comments	Download
M	content/renderer/render_widget.h	View	1 2 3	2 chunks	+2 lines, -4 lines	0 comments	Download
M	content/renderer/render_widget.cc	View	1 2 3	10 chunks	+51 lines, -75 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

pfeldman

lgtm https://codereview.chromium.org/220263003/diff/30001/content/renderer/devtools/devtools_agent.cc File content/renderer/devtools/devtools_agent.cc (right): https://codereview.chromium.org/220263003/diff/30001/content/renderer/devtools/devtools_agent.cc#newcode222 content/renderer/devtools/devtools_agent.cc:222: void DevToolsAgent::enableDeviceEmulation( This method is going away, right?

6 years, 8 months ago (2014-04-02 08:40:16 UTC) #2

dgozman

jochen, could you please take a look as an owner? https://codereview.chromium.org/220263003/diff/30001/content/renderer/devtools/devtools_agent.cc File content/renderer/devtools/devtools_agent.cc (right): https://codereview.chromium.org/220263003/diff/30001/content/renderer/devtools/devtools_agent.cc#newcode222 ...

6 years, 8 months ago (2014-04-02 12:28:17 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/220263003/50001

6 years, 8 months ago (2014-04-03 13:50:46 UTC) #6

Message was sent while issue was closed.

Change committed as 261394

Expand Messages | Collapse Messages