Converts parts of ios/web to ARC

ios/web/BUILD.gn

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//ios/build/config.gni")
 import("//ios/web/js_compile.gni")
 import("//testing/test.gni")
 import("//tools/grit/grit_rule.gni")
 
-source_set("web") {
+source_set("web_arc") {
   deps = [
     ":core",
     ":js_resources",
     ":resources",
     ":user_agent",
     "//base",
     "//components/url_formatter",
     "//ios/net",
     "//ios/third_party/blink:html_tokenizer",
     "//mojo/public/cpp/system",
@@ skipping 34 matching lines @@
     "navigation/navigation_item_impl.h",
     "navigation/navigation_item_impl.mm",
     "navigation/navigation_manager_delegate.h",
     "navigation/navigation_manager_facade_delegate.h",
     "navigation/navigation_manager_impl.h",
     "navigation/navigation_manager_impl.mm",
     "navigation/nscoder_util.h",
     "navigation/nscoder_util.mm",
     "navigation/time_smoother.cc",
     "navigation/time_smoother.h",
+    "string_util.cc",
+    "url_scheme_util.mm",
+    "url_util.cc",
+    "web_kit_constants.cc",
+    "web_thread_impl.cc",
+    "web_thread_impl.h",
+    "web_view_creation_util.mm",

[Eugene But (OOO till 7-30), 2016/08/01 21:13:48]

Should |CreateWKWebView| be annotated with something?

[stkhapugin, 2016/08/18 17:09:36]

Solved with https://codereview.chromium.org/2239773002/

+  ]
+
+  libs = [ "WebKit.framework" ]
+
+  configs += [ "//build/config/compiler:enable_arc" ]
+}
+
+source_set("web") {
+  deps = [
+    ":core",
+    ":js_resources",
+    ":resources",
+    ":user_agent",
+    "//base",
+    "//components/url_formatter",
+    "//ios/net",
+    "//ios/third_party/blink:html_tokenizer",
+    "//mojo/public/cpp/system",
+    "//mojo/public/js",
+    "//net",
+    "//services/shell/public/cpp",
+    "//ui/base",
+    "//ui/gfx",
+    "//ui/gfx/geometry:geometry",
+    "//ui/resources",
+    "//url",
+  ]
+
+  public_deps = [
+    ":web_arc",
+  ]
+
+  sources = [
     "net/cert_host_pair.cc",
     "net/cert_host_pair.h",
     "net/cert_policy.cc",
     "net/cert_store_impl.cc",
     "net/cert_store_impl.h",
     "net/cert_verifier_block_adapter.cc",
     "net/cert_verifier_block_adapter.h",
     "net/certificate_policy_cache.cc",
     "net/clients/crw_js_injection_network_client.h",
     "net/clients/crw_js_injection_network_client.mm",
@@ skipping 87 matching lines @@
     "public/web_thread.h",
     "public/web_thread_delegate.h",
     "public/web_ui_ios_data_source.h",
     "public/web_view_creation_util.h",
     "public/webui/web_ui_ios.h",
     "public/webui/web_ui_ios_controller.cc",
     "public/webui/web_ui_ios_controller.h",
     "public/webui/web_ui_ios_controller_factory.h",
     "public/webui/web_ui_ios_message_handler.cc",
     "public/webui/web_ui_ios_message_handler.h",
-    "string_util.cc",
-    "url_scheme_util.mm",
-    "url_util.cc",
-    "web_kit_constants.cc",
     "web_state/blocked_popup_info.h",
     "web_state/blocked_popup_info.mm",
     "web_state/context_menu_params.mm",
     "web_state/credential.cc",
     "web_state/crw_pass_kit_downloader.h",
     "web_state/crw_pass_kit_downloader.mm",
     "web_state/crw_web_view_proxy_impl.h",
     "web_state/crw_web_view_proxy_impl.mm",
     "web_state/crw_web_view_scroll_view_proxy.mm",
     "web_state/error_translation_util.h",
@@ skipping 43 matching lines @@
     "web_state/web_state_impl.mm",
     "web_state/web_state_observer.mm",
     "web_state/web_state_observer_bridge.mm",
     "web_state/web_state_policy_decider.mm",
     "web_state/web_state_weak_ptr_factory.h",
     "web_state/web_state_weak_ptr_factory.mm",
     "web_state/web_view_internal_creation_util.h",
     "web_state/web_view_internal_creation_util.mm",
     "web_state/wk_web_view_security_util.h",
     "web_state/wk_web_view_security_util.mm",
-    "web_thread_impl.cc",
-    "web_thread_impl.h",
-    "web_view_creation_util.mm",
     "webui/crw_web_ui_manager.h",
     "webui/crw_web_ui_manager.mm",
     "webui/crw_web_ui_page_builder.h",
     "webui/crw_web_ui_page_builder.mm",
     "webui/mojo_facade.h",
     "webui/mojo_facade.mm",
     "webui/mojo_js_constants.cc",
     "webui/mojo_js_constants.h",
     "webui/shared_resources_data_source_ios.h",
     "webui/shared_resources_data_source_ios.mm",
     "webui/url_data_manager_ios.cc",
     "webui/url_data_manager_ios.h",
     "webui/url_data_manager_ios_backend.h",
     "webui/url_data_manager_ios_backend.mm",
     "webui/url_data_source_ios.mm",
     "webui/url_data_source_ios_impl.cc",
     "webui/url_data_source_ios_impl.h",
     "webui/url_fetcher_block_adapter.h",
     "webui/url_fetcher_block_adapter.mm",
     "webui/web_ui_ios_controller_factory_registry.cc",
     "webui/web_ui_ios_controller_factory_registry.h",
     "webui/web_ui_ios_data_source_impl.h",
     "webui/web_ui_ios_data_source_impl.mm",
     "webui/web_ui_ios_impl.h",
     "webui/web_ui_ios_impl.mm",
   ]
 
   libs = [ "WebKit.framework" ]
+
+  allow_circular_includes_from = [ ":web_arc" ]
 }
 
 source_set("core") {
   deps = [
     "//base",
     "//url",
   ]
 
   sources = [
     "crw_network_activity_indicator_manager.h",
@@ skipping 288 matching lines @@
 }
 
 grit("resources") {
   source = "ios_web_resources.grd"
   use_qualified_include = true
   outputs = [
     "grit/ios_web_resources.h",
     "ios_web_resources.pak",
   ]
 }