Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1252)

Side by Side Diff: runtime/bin/vmservice/loader.dart

Issue 2202593002: Fix shutdown loaders (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 part of vmservice_io; 5 part of vmservice_io;
6 6
7 _sanitizeWindowsPath(path) { 7 _sanitizeWindowsPath(path) {
8 // For Windows we need to massage the paths a bit according to 8 // For Windows we need to massage the paths a bit according to
9 // http://blogs.msdn.com/b/ie/archive/2006/12/06/file-uris-in-windows.aspx 9 // http://blogs.msdn.com/b/ie/archive/2006/12/06/file-uris-in-windows.aspx
10 // 10 //
(...skipping 873 matching lines...) Expand 10 before | Expand all | Expand 10 after
884 // Shutdown all active loaders by sending an error message. 884 // Shutdown all active loaders by sending an error message.
885 void shutdownLoaders() { 885 void shutdownLoaders() {
886 String message = 'Service shutdown'; 886 String message = 'Service shutdown';
887 if (_httpClient != null) { 887 if (_httpClient != null) {
888 _httpClient.close(force: true); 888 _httpClient.close(force: true);
889 _httpClient = null; 889 _httpClient = null;
890 } 890 }
891 isolateEmbedderData.values.toList().forEach((IsolateLoaderState ils) { 891 isolateEmbedderData.values.toList().forEach((IsolateLoaderState ils) {
892 ils.cleanup(); 892 ils.cleanup();
893 assert(ils.sp != null); 893 assert(ils.sp != null);
894 _sendResourceResponse(ils.sp, 1, null, null, message); 894 _sendResourceResponse(ils.sp, 1, null, null, null, message);
895 }); 895 });
896 } 896 }
897 897
898 // See Dart_LibraryTag in dart_api.h 898 // See Dart_LibraryTag in dart_api.h
899 const _Dart_kCanonicalizeUrl = 0; // Canonicalize the URL. 899 const _Dart_kCanonicalizeUrl = 0; // Canonicalize the URL.
900 const _Dart_kScriptTag = 1; // Load the root script. 900 const _Dart_kScriptTag = 1; // Load the root script.
901 const _Dart_kSourceTag = 2; // Load a part source. 901 const _Dart_kSourceTag = 2; // Load a part source.
902 const _Dart_kImportTag = 3; // Import a library. 902 const _Dart_kImportTag = 3; // Import a library.
903 903
904 // Extra requests. Keep these in sync between loader.dart and builtin.dart. 904 // Extra requests. Keep these in sync between loader.dart and builtin.dart.
(...skipping 161 matching lines...) Expand 10 before | Expand all | Expand 10 after
1066 _log('Unknown scheme (${pathUri.scheme}) in $pathUri.'); 1066 _log('Unknown scheme (${pathUri.scheme}) in $pathUri.');
1067 } 1067 }
1068 _sendExtensionImportResponse(sp, uri, libraryUri, null); 1068 _sendExtensionImportResponse(sp, uri, libraryUri, null);
1069 break; 1069 break;
1070 } 1070 }
1071 break; 1071 break;
1072 default: 1072 default:
1073 _log('Unknown loader request tag=$tag from $isolateId'); 1073 _log('Unknown loader request tag=$tag from $isolateId');
1074 } 1074 }
1075 } 1075 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698