Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2202583002: Hides the error bubble on scroll event (Closed)

Created:
4 years, 4 months ago by Moe
Modified:
4 years, 4 months ago
Reviewers:
achuithb, jdufault
CC:
chromium-reviews, dzhioev+watch_chromium.org, achuith+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Hides the error bubble on scroll event BUG=631445 Committed: https://crrev.com/ab5c7c386152ea015ae9a25d2eca52f5bd369e73 Cr-Commit-Position: refs/heads/master@{#409181}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M ui/login/bubble.js View 2 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (10 generated)
Moe
Hi Achuith, In the MD User Manager if there are enough profiles we get a ...
4 years, 4 months ago (2016-08-01 15:53:37 UTC) #5
achuithb
Jake, could you please take a look?
4 years, 4 months ago (2016-08-01 17:55:18 UTC) #9
jdufault
lgtm
4 years, 4 months ago (2016-08-01 18:00:26 UTC) #10
achuithb
lgtm
4 years, 4 months ago (2016-08-01 23:55:44 UTC) #11
Moe
On 2016/08/01 23:55:44, achuithb wrote: > lgtm Thank you.
4 years, 4 months ago (2016-08-02 13:34:34 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2202583002/1
4 years, 4 months ago (2016-08-02 13:37:15 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-02 13:41:48 UTC) #16
commit-bot: I haz the power
4 years, 4 months ago (2016-08-02 13:43:34 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ab5c7c386152ea015ae9a25d2eca52f5bd369e73
Cr-Commit-Position: refs/heads/master@{#409181}

Powered by Google App Engine
This is Rietveld 408576698