|
|
Chromium Code Reviews
DescriptionHides the error bubble on scroll event
BUG=631445
Committed: https://crrev.com/ab5c7c386152ea015ae9a25d2eca52f5bd369e73
Cr-Commit-Position: refs/heads/master@{#409181}
Patch Set 1 #
Messages
Total messages: 18 (10 generated)
The CQ bit was checked by mahmadi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Hides the error bubble on scroll event BUG=631445 ========== to ========== Hides the error bubble on scroll event BUG=631445 ==========
mahmadi@chromium.org changed reviewers: + achuith@chromium.org
Hi Achuith, In the MD User Manager if there are enough profiles we get a scrollbar. The login error bubble currently doesn't hide itself on scroll which doesn't look very nice (pls refer to the bug for the current and the proposed behavior recordings). This patch addresses the issue. Please take a look.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
achuith@chromium.org changed reviewers: + jdufault@chromium.org
Jake, could you please take a look?
lgtm
lgtm
On 2016/08/01 23:55:44, achuithb wrote: > lgtm Thank you.
The CQ bit was checked by mahmadi@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Hides the error bubble on scroll event BUG=631445 ========== to ========== Hides the error bubble on scroll event BUG=631445 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Hides the error bubble on scroll event BUG=631445 ========== to ========== Hides the error bubble on scroll event BUG=631445 Committed: https://crrev.com/ab5c7c386152ea015ae9a25d2eca52f5bd369e73 Cr-Commit-Position: refs/heads/master@{#409181} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/ab5c7c386152ea015ae9a25d2eca52f5bd369e73 Cr-Commit-Position: refs/heads/master@{#409181} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
