tests/lib/async/stream_periodic_test.dart - Issue 2202533003: Return futures on Stream.cancel when possible.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/lib/async/stream_periodic_test.dart

Issue 2202533003: Return futures on Stream.cancel when possible. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Add test that asFuture waits for cancel-future. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tests/lib/async/stream_periodic_test.dart

diff --git a/tests/lib/async/stream_periodic_test.dart b/tests/lib/async/stream_periodic_test.dart

index b333966065bd78c19ff70e73ec83c92227443e96..f755d76ef41f9c958ad9afe0839824dd338d27a2 100644

--- a/tests/lib/async/stream_periodic_test.dart

+++ b/tests/lib/async/stream_periodic_test.dart

@@ -16,7 +16,10 @@ main() {

subscription = stream.listen(expectAsync((data) {

expect(data, isNull);

receivedCount++;

- if (receivedCount == 5) subscription.cancel();

+ if (receivedCount == 5) {

+ var future = subscription.cancel();

+ expect(future, completes);

+ }

}, count: 5));

});

}