sdk/lib/async/stream_transformers.dart - Issue 2202533003: Return futures on Stream.cancel when possible.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/async/stream_transformers.dart

Issue 2202533003: Return futures on Stream.cancel when possible. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Add test that asFuture waits for cancel-future. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sdk/lib/async/stream_transformers.dart

diff --git a/sdk/lib/async/stream_transformers.dart b/sdk/lib/async/stream_transformers.dart

index e0982da4260ec621621a82b526aa21dac87f2be4..7542c6b88cde43029d1fca046d99781dac558250 100644

--- a/sdk/lib/async/stream_transformers.dart

+++ b/sdk/lib/async/stream_transformers.dart

@@ -109,7 +109,7 @@ class _SinkTransformerStreamSubscription<S, T>

if (_isSubscribed) {

StreamSubscription subscription = _subscription;

_subscription = null;

- subscription.cancel();

+ return subscription.cancel();

}

return null;

}