Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1443)

Unified Diff: third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp

Issue 2202493002: NOT FOR REVIEW: Fullscreen WIP (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp b/third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp
index 9e1171988125dc51966ea8542e0e71df8278d26d..8c2647019189f1df95a3daad878f0571772d22ce 100644
--- a/third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp
+++ b/third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp
@@ -496,30 +496,7 @@ bool WebRemoteFrameImpl::isIgnoredForHitTest() const {
return owner->layoutObject()->style()->pointerEvents() == PE_NONE;
}
-void WebRemoteFrameImpl::willEnterFullscreen() {
- // This should only ever be called when the FrameOwner is local.
- HTMLFrameOwnerElement* ownerElement =
- toHTMLFrameOwnerElement(frame()->owner());
-
- // Call requestFullscreen() on |ownerElement| to make it the provisional
- // fullscreen element in FullscreenController, and to prepare
- // fullscreenchange events that will need to fire on it and its (local)
- // ancestors. The events will be triggered if/when fullscreen is entered.
- //
- // Passing |forCrossProcessAncestor| to requestFullscreen is necessary
- // because:
- // - |ownerElement| will need :-webkit-full-screen-ancestor style in
- // addition to :-webkit-full-screen.
- // - there's no need to resend the ToggleFullscreen IPC to the browser
- // process.
- //
- // TODO(alexmos): currently, this assumes prefixed requests, but in the
- // future, this should plumb in information about which request type
- // (prefixed or unprefixed) to use for firing fullscreen events.
- Fullscreen::from(ownerElement->document())
- .requestFullscreen(*ownerElement, Fullscreen::PrefixedRequest,
- true /* forCrossProcessAncestor */);
-}
+void WebRemoteFrameImpl::willEnterFullscreen() {}
WebRemoteFrameImpl::WebRemoteFrameImpl(WebTreeScopeType scope,
WebRemoteFrameClient* client)
« no previous file with comments | « third_party/WebKit/Source/web/WebPluginContainerImpl.cpp ('k') | third_party/WebKit/Source/web/tests/WebFrameTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698