Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 2202453002: Remove the CSS Properties API (Closed)

Created:
4 years, 4 months ago by sashab
Modified:
4 years, 4 months ago
Reviewers:
dstockwell
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis, esprehn
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the CSS Properties API Remove the core/css/properties/ folder, since it's currently dead code. Will re-add when the Ribbon project starts up again. This is a revert of crrev.com/1431773002. BUG=545324 Committed: https://crrev.com/b7b69c39719bebbb75eed0a912335e18e7935f66 Cr-Commit-Position: refs/heads/master@{#408915}

Patch Set 1 #

Patch Set 2 : More removals #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -138 lines) Patch
M third_party/WebKit/Source/core/core.gypi View 1 1 chunk +0 lines, -3 lines 0 comments Download
D third_party/WebKit/Source/core/css/properties/CSSPropertyDescriptor.h View 1 chunk +0 lines, -63 lines 0 comments Download
D third_party/WebKit/Source/core/css/properties/CSSPropertyDescriptor.cpp View 1 chunk +0 lines, -38 lines 0 comments Download
D third_party/WebKit/Source/core/css/properties/CSSPropertyFunctions.h View 1 chunk +0 lines, -34 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
sashab
dstockwell rs please :)
4 years, 4 months ago (2016-08-01 05:16:41 UTC) #5
dstockwell
lgtm 😞
4 years, 4 months ago (2016-08-01 05:34:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2202453002/20001
4 years, 4 months ago (2016-08-01 05:38:49 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-01 06:14:43 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-01 06:17:54 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b7b69c39719bebbb75eed0a912335e18e7935f66
Cr-Commit-Position: refs/heads/master@{#408915}

Powered by Google App Engine
This is Rietveld 408576698