Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2202433002: MD Settings: Inherit font size in passwords/autofill shared menu (Closed)

Created:
4 years, 4 months ago by tsergeant
Modified:
4 years, 4 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Inherit font size in passwords/autofill shared menu Switching to a native button element caused these elements to use the default User Agent stylesheet fonts. This caused the menu items to render in the system font rather than Roboto, and to not adjust to changes in font size preferences. BUG=629811 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/d72249ba3fa4ab9671cf9327aa58e7f5a86868b1 Cr-Commit-Position: refs/heads/master@{#409088}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/resources/settings/passwords_and_forms_page/passwords_shared_css.html View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
tsergeant
PTAL
4 years, 4 months ago (2016-08-01 00:26:24 UTC) #4
Dan Beam
lgtm
4 years, 4 months ago (2016-08-01 19:20:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2202433002/1
4 years, 4 months ago (2016-08-01 23:37:32 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-01 23:40:53 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-01 23:46:00 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d72249ba3fa4ab9671cf9327aa58e7f5a86868b1
Cr-Commit-Position: refs/heads/master@{#409088}

Powered by Google App Engine
This is Rietveld 408576698