Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 220243010: Clip Scrollbar painting like contents painting in ScrollView (Closed)

Created:
6 years, 8 months ago by leviw_travelin_and_unemployed
Modified:
6 years, 8 months ago
CC:
blink-reviews
Visibility:
Public.

Description

Clip Scrollbar painting like contents painting in ScrollView Previously, it was possible to paint a scroll corner that was larger than the iframe it was attached to, effectively enabling it to paint over parts of the parent frame. This change clips scrollbar painting the same way we clip contents. BUG=331168 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170625

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -0 lines) Patch
A LayoutTests/scrollbars/custom-scrollbars-paint-outside-iframe.html View 1 chunk +11 lines, -0 lines 0 comments Download
A LayoutTests/scrollbars/custom-scrollbars-paint-outside-iframe-expected.html View 1 chunk +11 lines, -0 lines 0 comments Download
M Source/platform/scroll/ScrollView.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
leviw_travelin_and_unemployed
6 years, 8 months ago (2014-04-01 23:32:08 UTC) #1
esprehn
lgtm, crazy bug
6 years, 8 months ago (2014-04-01 23:39:42 UTC) #2
leviw_travelin_and_unemployed
The CQ bit was checked by leviw@chromium.org
6 years, 8 months ago (2014-04-01 23:41:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/leviw@chromium.org/220243010/1
6 years, 8 months ago (2014-04-01 23:41:53 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-02 00:42:04 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 8 months ago (2014-04-02 00:42:04 UTC) #6
leviw_travelin_and_unemployed
The CQ bit was checked by leviw@chromium.org
6 years, 8 months ago (2014-04-02 01:09:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/leviw@chromium.org/220243010/1
6 years, 8 months ago (2014-04-02 01:09:39 UTC) #8
commit-bot: I haz the power
6 years, 8 months ago (2014-04-02 02:15:28 UTC) #9
Message was sent while issue was closed.
Change committed as 170625

Powered by Google App Engine
This is Rietveld 408576698