[Offline Page]Enable share offline page from online tab

chrome/android/java/src/org/chromium/chrome/browser/offlinepages/ClientId.java

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.offlinepages;
 
 import org.chromium.components.bookmarks.BookmarkId;
 
 /**
  * Object to hold a client identifier for an offline page.
@@ skipping 31 matching lines @@
 
     /**
      * Create a client id for a bookmark
      * @param id The bookmark id to wrap.
      * @return A {@link ClientId} that represents this BookmarkId.
      */
     public static ClientId createClientIdForBookmarkId(BookmarkId id) {
         if (id == null) return null;
         return new ClientId(OfflinePageBridge.BOOKMARK_NAMESPACE, id.toString());
     }
+
+    /**
+     * Create a client id for a tab with no bookmark associated with

[fgorski, 2016/08/08 17:59:22]

nit: add a period at the end of the sentence.

[Vivian, 2016/08/08 21:40:36]

Done.

+     * @param id The tab id to wrap.
+     * @return A {@link ClientId} that represents this TabId.
+     */
+    public static ClientId createClientIdForTabId(int id) {
+        return new ClientId(OfflinePageBridge.SHARE_NAMESPACE, Integer.toString(id));

[fgorski, 2016/08/08 17:59:22]

could you please create a GUID instead of basing this off the Tab ID?

Here is a sample code:
// Download UI needs "async_loading" namespace and a random (type 4) GUID.
String uuid = UUID.randomUUID().toString();
ClientId clientId = new ClientId("async_loading", uuid);
savePageLater(url, clientId);


Actually I very much like the idea of having this code here in ClientID.

[Vivian, 2016/08/08 21:40:36]

Done.

+    }
 }