chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc - Issue 2202373002: Ignore OnBubbleHidden() event when the password bubble is reopened.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc

Issue 2202373002: Ignore OnBubbleHidden() event when the password bubble is reopened. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: delete proxy Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc ('K') | « chrome/browser/ui/passwords/passwords_model_delegate_mock.cc ('k') | chrome/browser/ui/views/passwords/manage_passwords_bubble_view_interactive_uitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc

diff --git a/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc b/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc

index 74c26942ac5d6b8d9f3f9ff0fff23edd446f2076..09464ec839572ff665e5286d946017f1bd251f0c 100644

--- a/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc

+++ b/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc

@@ -11,6 +11,7 @@

#include "chrome/browser/ui/browser.h"

#include "chrome/browser/ui/browser_finder.h"

#include "chrome/browser/ui/exclusive_access/fullscreen_controller.h"

+#include "chrome/browser/ui/passwords/passwords_model_delegate.h"

#include "chrome/browser/ui/views/frame/browser_view.h"

#include "chrome/browser/ui/views/passwords/credentials_item_view.h"

#include "chrome/browser/ui/views/passwords/credentials_selection_view.h"

@@ -771,7 +772,7 @@ void ManagePasswordsBubbleView::ActivateBubble() {

}

content::WebContents* ManagePasswordsBubbleView::web_contents() const {

- return model_.web_contents();

+ return model_.GetWebContents();

}

ManagePasswordsBubbleView::ManagePasswordsBubbleView(

@@ -779,7 +780,7 @@ ManagePasswordsBubbleView::ManagePasswordsBubbleView(

views::View* anchor_view,

DisplayReason reason)

: LocationBarBubbleDelegateView(anchor_view, web_contents),

- model_(web_contents,

+ model_(PasswordsModelDelegateFromWebContents(web_contents),

reason == AUTOMATIC ? ManagePasswordsBubbleModel::AUTOMATIC

: ManagePasswordsBubbleModel::USER_ACTION),

initially_focused_view_(nullptr) {