chrome/browser/ui/cocoa/passwords/passwords_bubble_cocoa.mm - Issue 2202373002: Ignore OnBubbleHidden() event when the password bubble is reopened.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/passwords/passwords_bubble_cocoa.mm

Issue 2202373002: Ignore OnBubbleHidden() event when the password bubble is reopened. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: delete proxy Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/passwords/base_passwords_controller_test.mm ('k') | chrome/browser/ui/cocoa/passwords/passwords_bubble_cocoa_unittest.mm » ('j') | chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/passwords/passwords_bubble_cocoa.mm

diff --git a/chrome/browser/ui/cocoa/passwords/passwords_bubble_cocoa.mm b/chrome/browser/ui/cocoa/passwords/passwords_bubble_cocoa.mm

index 8c871a9b6d9b6df94372684c5ac80731118dc133..d5e520aa1f95ff367d1f59e4ec006f0767bb715e 100644

--- a/chrome/browser/ui/cocoa/passwords/passwords_bubble_cocoa.mm

+++ b/chrome/browser/ui/cocoa/passwords/passwords_bubble_cocoa.mm

@@ -13,6 +13,7 @@

#include "chrome/browser/ui/cocoa/location_bar/manage_passwords_decoration.h"

#import "chrome/browser/ui/cocoa/passwords/passwords_bubble_controller.h"

#include "chrome/browser/ui/passwords/manage_passwords_icon.h"

+#include "chrome/browser/ui/passwords/passwords_model_delegate.h"

#include "content/public/browser/web_contents.h"

typedef void (^Callback)(void);

@@ -43,7 +44,8 @@ ManagePasswordsBubbleCocoa::ManagePasswordsBubbleCocoa(

content::WebContents* webContents,

ManagePasswordsBubbleModel::DisplayReason displayReason,

ManagePasswordsIcon* icon)

- : model_(webContents, displayReason),

+ : model_(PasswordsModelDelegateFromWebContents(webContents),

+ displayReason),

icon_(icon),

controller_(nil),

webContents_(webContents),