Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Unified Diff: chrome/browser/password_manager/credential_manager_browsertest.cc

Issue 2202373002: Ignore OnBubbleHidden() event when the password bubble is reopened. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: delete proxy Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/credential_manager_browsertest.cc
diff --git a/chrome/browser/password_manager/credential_manager_browsertest.cc b/chrome/browser/password_manager/credential_manager_browsertest.cc
index 2e8dc797052c8ae74dcb6577d5daec15b53d7cb1..14cd6790f52a17b97cf3c232eea4f327ccd0197f 100644
--- a/chrome/browser/password_manager/credential_manager_browsertest.cc
+++ b/chrome/browser/password_manager/credential_manager_browsertest.cc
@@ -44,8 +44,8 @@ class CredentialManagerBrowserTest : public PasswordManagerBrowserTestBase {
CredentialManagerBrowserTest() = default;
bool IsShowingAccountChooser() {
- return PasswordsModelDelegateFromWebContents(WebContents())->GetState() ==
- password_manager::ui::CREDENTIAL_REQUEST_STATE;
+ return PasswordsModelDelegateFromWebContents(WebContents())->
+ GetState() == password_manager::ui::CREDENTIAL_REQUEST_STATE;
}
// Make sure that the password store processed all the previous calls which
@@ -93,8 +93,9 @@ IN_PROC_BROWSER_TEST_F(CredentialManagerBrowserTest,
"navigator.credentials.get({password: true})"
".then(cred => window.location = '/password/done.html')"));
WaitForPasswordStore();
- ASSERT_EQ(password_manager::ui::CREDENTIAL_REQUEST_STATE,
- PasswordsModelDelegateFromWebContents(WebContents())->GetState());
+ ASSERT_EQ(
+ password_manager::ui::CREDENTIAL_REQUEST_STATE,
+ PasswordsModelDelegateFromWebContents(WebContents())->GetState());
PasswordsModelDelegateFromWebContents(WebContents())->ChooseCredential(
signin_form,
password_manager::CredentialType::CREDENTIAL_TYPE_PASSWORD);

Powered by Google App Engine
This is Rietveld 408576698