chrome/browser/ui/views/passwords/manage_passwords_bubble_view_interactive_uitest.cc - Issue 2202373002: Ignore OnBubbleHidden() event when the password bubble is reopened.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/passwords/manage_passwords_bubble_view_interactive_uitest.cc

Issue 2202373002: Ignore OnBubbleHidden() event when the password bubble is reopened. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nits Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc ('K') | « chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc ('k') | chrome/chrome_browser_ui.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/passwords/manage_passwords_bubble_view_interactive_uitest.cc

diff --git a/chrome/browser/ui/views/passwords/manage_passwords_bubble_view_interactive_uitest.cc b/chrome/browser/ui/views/passwords/manage_passwords_bubble_view_interactive_uitest.cc

index 914c22ba7484d699bd6abf7319898dc562e266cc..a953ba90f21b10df928f56100b00a7ab3322978a 100644

--- a/chrome/browser/ui/views/passwords/manage_passwords_bubble_view_interactive_uitest.cc

+++ b/chrome/browser/ui/views/passwords/manage_passwords_bubble_view_interactive_uitest.cc

@@ -14,7 +14,7 @@

#include "build/build_config.h"

#include "chrome/browser/ui/browser.h"

#include "chrome/browser/ui/passwords/manage_passwords_test.h"

-#include "chrome/browser/ui/passwords/passwords_model_delegate.h"

+#include "chrome/browser/ui/passwords/passwords_model_delegate_proxy.h"

#include "chrome/browser/ui/tabs/tab_strip_model.h"

#include "chrome/browser/ui/views/frame/browser_view.h"

#include "chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h"

@@ -316,8 +316,9 @@ IN_PROC_BROWSER_TEST_F(ManagePasswordsBubbleViewTest, AutoSignin) {

content::RunAllPendingInMessageLoop();

content::WebContents* web_contents =

browser()->tab_strip_model()->GetActiveWebContents();

- EXPECT_EQ(password_manager::ui::MANAGE_STATE,

- PasswordsModelDelegateFromWebContents(web_contents)->GetState());

+ EXPECT_EQ(

+ password_manager::ui::MANAGE_STATE,

+ PasswordsModelDelegateProxyFromWebContents(web_contents)->GetState());

}

IN_PROC_BROWSER_TEST_F(ManagePasswordsBubbleViewTest, AutoSigninNoFocus) {