Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2867)

Unified Diff: chrome/browser/ui/cocoa/passwords/base_passwords_controller_test.h

Issue 2202373002: Ignore OnBubbleHidden() event when the password bubble is reopened. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nits Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/passwords/base_passwords_controller_test.h
diff --git a/chrome/browser/ui/cocoa/passwords/base_passwords_controller_test.h b/chrome/browser/ui/cocoa/passwords/base_passwords_controller_test.h
index 7153b8905ce0a371f85112794a49eee6979e79ec..14b9775215bbf74e6f4fa663e8d1020641237c41 100644
--- a/chrome/browser/ui/cocoa/passwords/base_passwords_controller_test.h
+++ b/chrome/browser/ui/cocoa/passwords/base_passwords_controller_test.h
@@ -10,13 +10,12 @@
#include "chrome/browser/ui/cocoa/cocoa_test_helper.h"
#import "chrome/browser/ui/cocoa/passwords/base_passwords_content_view_controller.h"
#include "chrome/browser/ui/passwords/manage_passwords_bubble_model.h"
+#include "chrome/browser/ui/passwords/passwords_model_delegate_mock.h"
namespace content {
class WebContents;
} // namespace content
-
-class ManagePasswordsUIControllerMock;
-class ManagePasswordsBubbleModel;
+class PasswordsModelDelegateMock;
// Helper delegate for testing the views of the password management bubble.
@interface ContentViewDelegateMock : NSObject<BasePasswordsContentViewDelegate>
@@ -32,7 +31,9 @@ class ManagePasswordsControllerTest : public CocoaProfileTest {
~ManagePasswordsControllerTest() override;
void SetUp() override;
- ManagePasswordsUIControllerMock* ui_controller() { return ui_controller_; }
+ PasswordsModelDelegateMock* ui_controller() {
+ return ui_controller_.get();
+ }
ContentViewDelegateMock* delegate() { return delegate_.get(); }
ManagePasswordsBubbleModel* GetModelAndCreateIfNull();
@@ -47,7 +48,7 @@ class ManagePasswordsControllerTest : public CocoaProfileTest {
virtual ManagePasswordsBubbleModel::DisplayReason GetDisplayReason() const;
private:
- ManagePasswordsUIControllerMock* ui_controller_;
+ std::unique_ptr<PasswordsModelDelegateMock> ui_controller_;
vabr (Chromium) 2016/08/05 14:14:04 nit: #include <memory> for unique_ptr
vasilii 2016/08/05 16:45:19 Done.
std::unique_ptr<content::WebContents> test_web_contents_;
std::unique_ptr<ManagePasswordsBubbleModel> model_;
base::scoped_nsobject<ContentViewDelegateMock> delegate_;

Powered by Google App Engine
This is Rietveld 408576698