Ignore OnBubbleHidden() event when the password bubble is reopened.

chrome/browser/ui/passwords/manage_passwords_ui_controller.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_UI_CONTROLLER_H_
 #define CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_UI_CONTROLLER_H_
 
+#include <memory>
 #include <vector>
 
 #include "base/macros.h"
 #include "chrome/browser/ui/passwords/manage_passwords_state.h"
 #include "chrome/browser/ui/passwords/passwords_client_ui_delegate.h"
 #include "chrome/browser/ui/passwords/passwords_model_delegate.h"
 #include "chrome/common/features.h"
 #include "components/password_manager/core/browser/password_store.h"
 #include "content/public/browser/web_contents_observer.h"
 #include "content/public/browser/web_contents_user_data.h"
@@ skipping 54 matching lines @@
       const password_manager::PasswordStoreChangeList& changes) override;
 
   // Set the state of the Omnibox icon, and possibly show the associated bubble
   // without user interaction.
   virtual void UpdateIconAndBubbleState(ManagePasswordsIconView* icon);
 
   bool IsAutomaticallyOpeningBubble() const {
     return bubble_status_ == SHOULD_POP_UP;
   }
 
+  base::WeakPtr<PasswordsModelDelegate> GetModelDelegateProxy();
+
   // PasswordsModelDelegate:
+  content::WebContents* GetWebContents() const override;
   const GURL& GetOrigin() const override;
   password_manager::ui::State GetState() const override;
   const autofill::PasswordForm& GetPendingPassword() const override;
   bool IsPasswordOverridden() const override;
   const std::vector<const autofill::PasswordForm*>& GetCurrentForms()
       const override;
   const std::vector<const autofill::PasswordForm*>& GetFederatedForms()
       const override;
   password_manager::InteractionsStats* GetCurrentInteractionStats() const
       override;
   void OnBubbleShown() override;
   void OnBubbleHidden() override;
   void OnNoInteractionOnUpdate() override;
   void OnNopeUpdateClicked() override;
   void NeverSavePassword() override;
   void SavePassword() override;
   void UpdatePassword(const autofill::PasswordForm& password_form) override;
   void ChooseCredential(
-      autofill::PasswordForm form,
+      const autofill::PasswordForm& form,
       password_manager::CredentialType credential_type) override;
   void NavigateToExternalPasswordManager() override;
   void NavigateToSmartLockHelpPage() override;
   void NavigateToPasswordManagerSettingsPage() override;
   void NavigateToChromeSignIn() override;
   void OnDialogHidden() override;
 
  protected:
   explicit ManagePasswordsUIController(
       content::WebContents* web_contents);
@@ skipping 53 matching lines @@
   void WebContentsDestroyed() override;
 
   // The wrapper around current state and data.
   ManagePasswordsState passwords_data_;
 
   // The controller for the blocking dialogs.
   std::unique_ptr<PasswordDialogControllerImpl> dialog_controller_;
 
   BubbleStatus bubble_status_;
 
+  // The bubbles of different types can pop up unpredictably superseding each
+  // other. However, closing the bubble may affect the state of
+  // ManagePasswordsUIController internally. This is undesired if
+  // ManagePasswordsUIController is in the process of opening a new bubble. The
+  // situation is worse on Windows where the bubble is destroyed asynchronously.
+  // Thus, OnBubbleHidden() can be called after the new one is shown. By that
+  // time the internal state of ManagePasswordsUIController has nothing to do
+  // with the old bubble.
+  // Invalidating all the weak pointers will detach the current bubble.
+  base::WeakPtrFactory<ManagePasswordsUIController> weak_ptr_factory_;
+
   DISALLOW_COPY_AND_ASSIGN(ManagePasswordsUIController);
 };
 
 #endif  // CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_UI_CONTROLLER_H_