Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 2202353002: gn: fix fiddle (Closed)

Created:
4 years, 4 months ago by mtklein_C
Modified:
4 years, 4 months ago
Reviewers:
jcgregorio
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

gn: fix fiddle - __SK_FORCE_IMAGE_DECODER_LINKING makes sure the PNG encoder is linked - updated path to make working with sample draw.cpp easier. No public API changes. TBR=reed@google.com BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2202353002 Committed: https://skia.googlesource.com/skia/+/5dbd27484641279b53369587c93ba0566c20a161

Patch Set 1 #

Patch Set 2 : fix #

Patch Set 3 : simpler #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M BUILD.gn View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M include/images/SkForceLinking.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M tools/fiddle/draw.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tools/fiddle/fiddle_main.cpp View 1 2 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (14 generated)
mtklein_C
4 years, 4 months ago (2016-08-02 17:38:37 UTC) #6
jcgregorio
lgtm
4 years, 4 months ago (2016-08-02 17:44:27 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2202353002/40001
4 years, 4 months ago (2016-08-02 17:54:05 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on master.client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/12028)
4 years, 4 months ago (2016-08-02 17:55:35 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2202353002/40001
4 years, 4 months ago (2016-08-02 17:55:54 UTC) #18
commit-bot: I haz the power
4 years, 4 months ago (2016-08-02 18:13:52 UTC) #20
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/5dbd27484641279b53369587c93ba0566c20a161

Powered by Google App Engine
This is Rietveld 408576698