Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Issue 2202333004: Update android test instructions. (Closed)

Created:
4 years, 4 months ago by jbudorick
Modified:
4 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update android test instructions. Nothing major, just cleaning up formatting etc. BUG= Committed: https://crrev.com/25c17388b8e91deea7105a9320b9e8edc0f82019 Cr-Commit-Position: refs/heads/master@{#409581}

Patch Set 1 #

Patch Set 2 : more cleaning #

Total comments: 4

Patch Set 3 : rnephew comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -49 lines) Patch
M docs/android_test_instructions.md View 1 2 8 chunks +58 lines, -49 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
jbudorick
4 years, 4 months ago (2016-08-03 17:01:07 UTC) #2
jbudorick
On 2016/08/03 17:01:07, jbudorick wrote: er, hold off on this, updating it more.
4 years, 4 months ago (2016-08-03 17:05:23 UTC) #3
jbudorick
ok, ptal
4 years, 4 months ago (2016-08-03 17:59:26 UTC) #5
rnephew (Reviews Here)
lgtm with nits. https://codereview.chromium.org/2202333004/diff/20001/docs/android_test_instructions.md File docs/android_test_instructions.md (right): https://codereview.chromium.org/2202333004/diff/20001/docs/android_test_instructions.md#newcode36 docs/android_test_instructions.md:36: #### Enable Asserts! Not that it ...
4 years, 4 months ago (2016-08-03 18:08:40 UTC) #6
jbudorick
https://codereview.chromium.org/2202333004/diff/20001/docs/android_test_instructions.md File docs/android_test_instructions.md (right): https://codereview.chromium.org/2202333004/diff/20001/docs/android_test_instructions.md#newcode36 docs/android_test_instructions.md:36: #### Enable Asserts! On 2016/08/03 18:08:39, rnephew (Reviews Here) ...
4 years, 4 months ago (2016-08-03 18:12:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2202333004/40001
4 years, 4 months ago (2016-08-03 18:13:29 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-03 18:53:23 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-03 18:55:09 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/25c17388b8e91deea7105a9320b9e8edc0f82019
Cr-Commit-Position: refs/heads/master@{#409581}

Powered by Google App Engine
This is Rietveld 408576698