Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Unified Diff: tools/perf/benchmarks/page_cycler.py

Issue 2202333002: Remove page_cycler.top_10_mobile. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/page_cycler.py
diff --git a/tools/perf/benchmarks/page_cycler.py b/tools/perf/benchmarks/page_cycler.py
index 21f3449e76b48a3f95bcbcb2731e488fd8d04bb2..c1100bce73e5106cc8a041f85c546438d014c140 100644
--- a/tools/perf/benchmarks/page_cycler.py
+++ b/tools/perf/benchmarks/page_cycler.py
@@ -117,6 +117,7 @@ class PageCyclerIntlKoThVi(_PageCycler):
@benchmark.Enabled('android')
+@benchmark.Disabled('all') # crbug.com/633222
shatch 2016/08/02 16:02:14 Is this right? This is kinda weird, since enabled
nednguyen 2016/08/02 16:54:30 Yeah, Enabled is white-listing, whereas Disabled i
class PageCyclerTop10Mobile(_PageCycler):
"""Page load time benchmark for the top 10 mobile web pages.
@@ -135,11 +136,6 @@ class PageCyclerTop10Mobile(_PageCycler):
stories.RemoveStory(found)
return stories
- @classmethod
- def ShouldDisable(cls, possible_browser):
- # http://crbug.com/633222 (Android Nexus 5).
- return possible_browser.platform.GetDeviceTypeName() == 'Nexus 5'
-
@benchmark.Disabled('android') # crbug.com/357326
class PageCyclerToughLayoutCases(_PageCycler):
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698