Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 220233013: Don't return null from ReplaceSelectionCommand::insertAsListItems() (Closed)

Created:
6 years, 8 months ago by yosin_UTC9
Modified:
6 years, 8 months ago
Reviewers:
yoichio, Yuta Kitamura
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Don't return null from ReplaceSelectionCommand::insertAsListItems() When trying to replace list by list, we insert list item instead of list itself, by calling insertAsListItems(). However, insertAsListItems() returns null when it takes empty list. This patch changes to ReplaceSelectionCommand::insertAsListItems() not to return null. BUG=238170 TEST=LayoutTests/editing/execCommand/crash-replacing-list-by-list.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170821

Patch Set 1 #

Total comments: 2

Patch Set 2 : 2014-04-03T01:25:13 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1 line) Patch
A LayoutTests/editing/execCommand/crash-replacing-list-by-list.html View 1 chunk +13 lines, -0 lines 0 comments Download
A + LayoutTests/editing/execCommand/crash-replacing-list-by-list-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/core/editing/ReplaceSelectionCommand.cpp View 1 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
yosin_UTC9
Could you review this patch? Thanks in advance. P.S. win_blink_rel bot failure isn't related to ...
6 years, 8 months ago (2014-04-02 08:55:02 UTC) #1
yoichio
lgtm
6 years, 8 months ago (2014-04-02 09:07:25 UTC) #2
Yuta Kitamura
I'm not sure if I could follow the implementation of insertAsListItems() completely... I'd like to ...
6 years, 8 months ago (2014-04-02 09:34:49 UTC) #3
yosin_UTC9
PTAL https://codereview.chromium.org/220233013/diff/1/Source/core/editing/ReplaceSelectionCommand.cpp File Source/core/editing/ReplaceSelectionCommand.cpp (right): https://codereview.chromium.org/220233013/diff/1/Source/core/editing/ReplaceSelectionCommand.cpp#newcode1085 Source/core/editing/ReplaceSelectionCommand.cpp:1085: if (!refNode || !refNode->inDocument()) On 2014/04/02 09:34:49, Yuta ...
6 years, 8 months ago (2014-04-03 05:01:49 UTC) #4
Yuta Kitamura
lgtm
6 years, 8 months ago (2014-04-03 05:10:38 UTC) #5
yosin_UTC9
The CQ bit was checked by yosin@chromium.org
6 years, 8 months ago (2014-04-03 05:44:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yosin@chromium.org/220233013/20001
6 years, 8 months ago (2014-04-03 05:44:24 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-03 05:47:54 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on blink_presubmit
6 years, 8 months ago (2014-04-03 05:47:54 UTC) #9
yosin_UTC9
The CQ bit was checked by yosin@chromium.org
6 years, 8 months ago (2014-04-04 03:33:38 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yosin@chromium.org/220233013/20001
6 years, 8 months ago (2014-04-04 03:33:40 UTC) #11
commit-bot: I haz the power
6 years, 8 months ago (2014-04-04 04:53:57 UTC) #12
Message was sent while issue was closed.
Change committed as 170821

Powered by Google App Engine
This is Rietveld 408576698