Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(751)

Issue 220233008: Move dispatchUnloadEvent to WebFrame, part 3/3. (Closed)

Created:
6 years, 8 months ago by Avi (use Gerrit)
Modified:
6 years, 8 months ago
Reviewers:
eseidel
CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Move dispatchUnloadEvent to WebFrame, part 3/3. BUG=357782 TEST=no change Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170661

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -18 lines) Patch
M Source/web/WebViewImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/WebViewImpl.cpp View 1 chunk +0 lines, -10 lines 0 comments Download
M public/web/WebView.h View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Avi (use Gerrit)
6 years, 8 months ago (2014-04-01 14:58:01 UTC) #1
eseidel
lgtm
6 years, 8 months ago (2014-04-01 17:33:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/220233008/1
6 years, 8 months ago (2014-04-01 17:33:43 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-01 17:52:58 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 8 months ago (2014-04-01 17:52:58 UTC) #5
Avi (use Gerrit)
The CQ bit was checked by avi@chromium.org
6 years, 8 months ago (2014-04-02 14:11:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/220233008/1
6 years, 8 months ago (2014-04-02 14:11:34 UTC) #7
commit-bot: I haz the power
6 years, 8 months ago (2014-04-02 15:20:30 UTC) #8
Message was sent while issue was closed.
Change committed as 170661

Powered by Google App Engine
This is Rietveld 408576698