Issue 220233006: PreParser fix: propagate reference erros properly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 220233006: PreParser fix: propagate reference erros properly. (Closed)

Created:
6 years, 8 months ago by marja

Modified:
6 years, 8 months ago

Reviewers:
rossberg

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

PreParser fix: propagate reference erros properly. For example, invalid left hand sides are reference errors. PreParser didn't use to produce this error ever, so the code for propagating reference errors properly was missing, and reference errors turned into syntax errors. R=rossberg@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=20408

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+51 lines, -33 lines)			Patch
M	src/parser.h	View	2 chunks	+6 lines, -5 lines	0 comments	Download
M	src/parser.cc	View	4 chunks	+13 lines, -8 lines	0 comments	Download
M	src/preparse-data.h	View	5 chunks	+19 lines, -12 lines	0 comments	Download
M	src/preparse-data.cc	View	2 chunks	+7 lines, -4 lines	0 comments	Download
M	src/preparse-data-format.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/preparser.cc	View	2 chunks	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

marja

6 years, 8 months ago (2014-04-01 14:18:02 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r20408 (presubmit successful).

Expand Messages | Collapse Messages