Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(574)

Issue 2202283003: Verify row bytes before alloc in BMP codec. (Closed)

Created:
4 years, 4 months ago by dsinclair
Modified:
4 years, 4 months ago
Reviewers:
Lei Zhang, Wei Li
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Verify row bytes before alloc in BMP codec. If the out_row_bytes is negative the alloc will fail. Verify the size before alloc and bail if it's negative. BUG=633381 Committed: https://pdfium.googlesource.com/pdfium/+/0a7552ffa04bfb0c0523bd9c88e55e82842f53a8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M core/fxcodec/lbmp/fx_bmp.cpp View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
dsinclair
PTAL.
4 years, 4 months ago (2016-08-02 19:10:53 UTC) #4
Lei Zhang
lgtm
4 years, 4 months ago (2016-08-02 19:12:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2202283003/1
4 years, 4 months ago (2016-08-02 19:16:57 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-08-02 19:36:11 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/0a7552ffa04bfb0c0523bd9c88e55e82842f...

Powered by Google App Engine
This is Rietveld 408576698