Introduce ::getPropertyInternal method to avoid duplication

Introduce ::getPropertyInternal method to avoid duplication

Document.cpp implements "getter" methods for some of the
Document object properties.
Some of the body of such methods are identical.

Patch introduces a ::getPropertyInternal private method
that gets rid of this duplication.

Namely the following properties' getters are cleaned up:
- "author", "creationDate", "creator", "keywords",
- "modDate", "producer", "subject" and "title"

No behavior change.

Committed: https://pdfium.googlesource.com/pdfium/+/ea3ff9eaaa508b9cbc7f52bc92d189eacbc7a935

[tonikitoo, 2016-08-02 15:37:02]

tonikitoo@igalia.com changed reviewers:
+ thestig@chromium.org, tsepez@chromium.org

[Tom Sepez, 2016-08-02 17:42:26]

On 2016/08/02 15:37:03, tonikitoo1 wrote:

Hi tonikitoo1, thanks for the patch.  It is a lot cleaner.

Is this your first PDFium submission?  If so, then welcome!
Next comes an obligatory question of "Have you signed a 
chromium contributor agreement?" I need to get this detail
out of the way before continuing.

You will also get to add yourself to the /AUTHORS file as well.

[tonikitoo, 2016-08-02 17:49:41]

On 2016/08/02 17:42:26, Tom Sepez wrote:
> On 2016/08/02 15:37:03, tonikitoo1 wrote:
> 
> Hi tonikitoo1, thanks for the patch.  It is a lot cleaner.

My pleasure.
 
> Is this your first PDFium submission?  If so, then welcome!
> Next comes an obligatory question of "Have you signed a 
> chromium contributor agreement?" I need to get this detail
> out of the way before continuing.

I have signed Chromium's contributor agreement in src/AUTHORS.
I actually fall under Igalia's corporate agreement (please see the line with
"Igalia S.L. <*@igalia.com>).
".
I wonder if I need to specifically sign a PDFium one? 

> You will also get to add yourself to the /AUTHORS file as well.

Ok, will reupload a new patchset touching AUTHORS.

[Tom Sepez, 2016-08-02 17:52:24]

>I have signed Chromium's contributor agreement in src/AUTHORS.
> I actually fall under Igalia's corporate agreement (please see the line with
> "Igalia S.L. <mailto:*@igalia.com>).
> ".
> I wonder if I need to specifically sign a PDFium one?
No, that's good enough.

[Tom Sepez, 2016-08-02 18:24:07]

The CQ bit was checked by tsepez@chromium.org

[Tom Sepez, 2016-08-02 18:24:07]

lgtm

[commit-bot: I haz the power, 2016-08-02 18:24:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-02 18:52:30]

Description was changed from

==========
Introduce ::getPropertyInternal method to avoid duplication

Document.cpp implements "getter" methods for some of the
Document object properties.
Some of the body of such methods are identical.

Patch introduces a ::getPropertyInternal private method
that gets rid of this duplication.

Namely the following properties' getters are cleaned up:
- "author", "creationDate", "creator", "keywords",
- "modDate", "producer", "subject" and "title"

No behavior change.
==========

to

==========
Introduce ::getPropertyInternal method to avoid duplication

Document.cpp implements "getter" methods for some of the
Document object properties.
Some of the body of such methods are identical.

Patch introduces a ::getPropertyInternal private method
that gets rid of this duplication.

Namely the following properties' getters are cleaned up:
- "author", "creationDate", "creator", "keywords",
- "modDate", "producer", "subject" and "title"

No behavior change.

Committed:
https://pdfium.googlesource.com/pdfium/+/ea3ff9eaaa508b9cbc7f52bc92d189eacbc7...
==========

[commit-bot: I haz the power, 2016-08-02 18:52:31]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/ea3ff9eaaa508b9cbc7f52bc92d189eacbc7...