Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2202233003:
Fixed ambient lighting calculations on SkLightingShader (Closed)
DescriptionFixed ambient lighting calculations on SkLightingShader
BUG=skia:5520
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2202233003
Committed: https://skia.googlesource.com/skia/+/9d65bb4795d14990daf08fba5a3de9404df4b913
Patch Set 1 #Patch Set 2 : Fixed double premul'ing on the ambient component #Messages
Total messages: 22 (13 generated)
Description was changed from ========== Fixed ambient lighting calculations on SkLightingShader BUG=skia: ========== to ========== Fixed ambient lighting calculations on SkLightingShader BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2202233003 ==========
Description was changed from ========== Fixed ambient lighting calculations on SkLightingShader BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2202233003 ========== to ========== Fixed ambient lighting calculations on SkLightingShader BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2202233003 ==========
dvonbeck@google.com changed reviewers: + egdaniel@google.com, robertphillips@google.com
dvonbeck@google.com changed reviewers: + fmenozzi@google.com
Description was changed from ========== Fixed ambient lighting calculations on SkLightingShader BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2202233003 ========== to ========== Fixed ambient lighting calculations on SkLightingShader BUG=skia:5520 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2202233003 ==========
lgtm
The CQ bit was checked by dvonbeck@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by dvonbeck@google.com
Actually, you're premultiplying twice. not lgtm
Fixed the double premul'ing on the GPU side
lgtm
The CQ bit was checked by dvonbeck@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by dvonbeck@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Fixed ambient lighting calculations on SkLightingShader BUG=skia:5520 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2202233003 ========== to ========== Fixed ambient lighting calculations on SkLightingShader BUG=skia:5520 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2202233003 Committed: https://skia.googlesource.com/skia/+/9d65bb4795d14990daf08fba5a3de9404df4b913 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/9d65bb4795d14990daf08fba5a3de9404df4b913 |
