Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(873)

Unified Diff: components/tracing/BUILD.gn

Issue 2202233002: Path evaluation to protobuf plugin. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Windows cross-compile in future Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/protobuf/proto_library.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/tracing/BUILD.gn
diff --git a/components/tracing/BUILD.gn b/components/tracing/BUILD.gn
index 1871b56cc1b42e19132f58d127de2eb0a94149af..0e3c97fab75c38ead482352bbec838df3f404da7 100644
--- a/components/tracing/BUILD.gn
+++ b/components/tracing/BUILD.gn
@@ -70,24 +70,6 @@ proto_library("proto_zero_testing_messages") {
generator_plugin_suffix = ".pbzero"
generate_cc = false
generate_python = false
-
- # TODO(kraynov) Move away this complex path evaluation and dependency
- # injection to proto_library.gni. All lines below should be removed.
- # The problem is that root_out_dir and root_build_dir may differ in case of
- # cross compilation. Also .exe will be appended on Windows.
-
- plugin_host_label = generator_plugin_label + "($host_toolchain)"
- generator_plugin =
- rebase_path(get_label_info(plugin_host_label, "root_out_dir") + "/" +
- get_label_info(plugin_host_label, "name"),
- root_build_dir)
- if (is_win) {
- generator_plugin += ".exe"
- }
-
- deps = [
- plugin_host_label,
- ]
}
source_set("unit_tests") {
« no previous file with comments | « no previous file | third_party/protobuf/proto_library.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698