Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 2202163002: Revert of [builtins] implement Array.prototype.includes in TurboFan (Closed)

Created:
4 years, 4 months ago by Michael Achenbach
Modified:
4 years, 4 months ago
CC:
danno, Jakob Kummerow, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [builtins] implement Array.prototype.includes in TurboFan (patchset #20 id:380001 of https://codereview.chromium.org/2146293003/ ) Reason for revert: [Sheriff] Breaks: https://build.chromium.org/p/client.v8.ports/builders/V8%20Arm%20-%20builder/builds/2592 Original issue's description: > [builtins] implement Array.prototype.includes in TurboFan > > BUG=v8:5162 > R=bmeurer@chromium.org, ishell@chromium.org > > Committed: https://crrev.com/a488b5d8eb111a4883dc400bd826d079420edd68 > Cr-Commit-Position: refs/heads/master@{#38223} TBR=adamk@chromium.org,bmeurer@chromium.org,cbruni@chromium.org,danno@chromium.org,ishell@chromium.org,littledan@chromium.org,caitp@igalia.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5162 Committed: https://crrev.com/c98f3a98d76acc484e0aec2bea7888795e92010e Cr-Commit-Position: refs/heads/master@{#38226}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+153 lines, -1887 lines) Patch
M src/builtins/builtins.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/builtins/builtins-array.cc View 4 chunks +16 lines, -484 lines 0 comments Download
M src/code-stub-assembler.h View 1 chunk +0 lines, -16 lines 0 comments Download
M src/code-stub-assembler.cc View 1 chunk +0 lines, -210 lines 0 comments Download
M src/code-stubs.cc View 1 chunk +72 lines, -2 lines 0 comments Download
M src/compiler/code-assembler.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/code-assembler.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/raw-machine-assembler.h View 1 chunk +2 lines, -3 lines 0 comments Download
M src/compiler/raw-machine-assembler.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/elements.h View 1 chunk +0 lines, -6 lines 0 comments Download
M src/elements.cc View 7 chunks +8 lines, -370 lines 0 comments Download
M src/factory.h View 1 chunk +0 lines, -10 lines 0 comments Download
M src/js/array.js View 3 chunks +43 lines, -1 line 0 comments Download
M src/js/typedarray.js View 3 chunks +3 lines, -23 lines 0 comments Download
M src/objects.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/objects-inl.h View 1 chunk +0 lines, -14 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/runtime/runtime-array.cc View 3 chunks +4 lines, -104 lines 0 comments Download
D test/mjsunit/es7/array-includes-receiver.js View 1 chunk +0 lines, -634 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Michael Achenbach
Created Revert of [builtins] implement Array.prototype.includes in TurboFan
4 years, 4 months ago (2016-08-02 06:52:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2202163002/1
4 years, 4 months ago (2016-08-02 06:52:16 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-02 06:52:37 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-08-02 06:54:04 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c98f3a98d76acc484e0aec2bea7888795e92010e
Cr-Commit-Position: refs/heads/master@{#38226}

Powered by Google App Engine
This is Rietveld 408576698