Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 2202143002: Fix tests: conformance_textures_image_bitmap_from_image_data on Android (Closed)

Created:
4 years, 4 months ago by xidachen
Modified:
4 years, 4 months ago
Reviewers:
jbroman, Justin Novosad
CC:
chromium-reviews, blink-reviews, Ken Russell (switch to Gerrit), Zhenyao Mo
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix tests: conformance_textures_image_bitmap_from_image_data on Android Right now these tests are failing, and the reason is that in our previous CL here: https://codereview.chromium.org/2183323003, we made a change such that the function swizzleImageData() is called only when kN32_SkColorType == kBGRA_8888_SkColorType. That means on the Android platform this function will not be called. What I didn't realize is that this function itself also contains flip the input data vertically which is required when flipY is true. Right now on the Android bots, whenever the flipY is true, these tests will fail. This CL changes the function swizzleImageData() so that this function determines whether swizle is needed or not based on this: kN32_SkColorType == kBGRA_8888_SkColorType BUG=633214 Committed: https://crrev.com/909e62f21bef265278f12a398af788e2c02060f8 Cr-Commit-Position: refs/heads/master@{#409225}

Patch Set 1 #

Patch Set 2 : remove an un-necessary blank line #

Patch Set 3 : fix compile error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -11 lines) Patch
M third_party/WebKit/Source/core/frame/ImageBitmap.cpp View 1 2 2 chunks +14 lines, -11 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
xidachen
PTAL
4 years, 4 months ago (2016-08-02 01:44:32 UTC) #2
Justin Novosad
On 2016/08/02 01:44:32, xidachen wrote: > PTAL lgtm
4 years, 4 months ago (2016-08-02 15:41:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2202143002/40001
4 years, 4 months ago (2016-08-02 17:36:31 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-02 17:41:18 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-02 17:43:29 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/909e62f21bef265278f12a398af788e2c02060f8
Cr-Commit-Position: refs/heads/master@{#409225}

Powered by Google App Engine
This is Rietveld 408576698