Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(816)

Issue 2202133002: MD WebUI: Do not restore focus from <cr-shared-menu> when closing with tap (Closed)

Created:
4 years, 4 months ago by tsergeant
Modified:
4 years, 4 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, dbeam+watch-elements_chromium.org, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, michaelpg+watch-elements_chromium.org, stevenjb+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD WebUI: Do not restore focus from <cr-shared-menu> when closing with tap This fixes issues where focus would move around unexpectedly while interacting with the menu using a mouse. Focus will still restore when the menu is closed with escape or the closeMenu function. BUG=628080 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/03a7e9b1731415b78007c697f1e4402f5510f843 Cr-Commit-Position: refs/heads/master@{#409145}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -4 lines) Patch
M chrome/browser/resources/md_history/list_container.js View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/data/webui/cr_elements/cr_shared_menu_tests.js View 4 chunks +32 lines, -3 lines 0 comments Download
M ui/webui/resources/cr_elements/cr_shared_menu/cr_shared_menu.js View 3 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
tsergeant
PTAL
4 years, 4 months ago (2016-08-02 01:34:54 UTC) #3
Dan Beam
lgtm
4 years, 4 months ago (2016-08-02 04:53:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2202133002/1
4 years, 4 months ago (2016-08-02 04:59:33 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-02 06:07:35 UTC) #7
commit-bot: I haz the power
4 years, 4 months ago (2016-08-02 06:08:58 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/03a7e9b1731415b78007c697f1e4402f5510f843
Cr-Commit-Position: refs/heads/master@{#409145}

Powered by Google App Engine
This is Rietveld 408576698