android_webview/java/src/org/chromium/android_webview/AwSettings.java - Issue 2202123002: Make WebView respond to device scale change

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/java/src/org/chromium/android_webview/AwSettings.java

Issue 2202123002: Make WebView respond to device scale change (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Combined two setSize methods again with question Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« android_webview/java/src/org/chromium/android_webview/AwContents.java ('K') | « android_webview/java/src/org/chromium/android_webview/AwContents.java ('k') | android_webview/tools/system_webview_shell/apk/AndroidManifest.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/java/src/org/chromium/android_webview/AwSettings.java

diff --git a/android_webview/java/src/org/chromium/android_webview/AwSettings.java b/android_webview/java/src/org/chromium/android_webview/AwSettings.java

index ea93c487e7361672424d75e3a878d6b2ebc4c5c2..398f8462e744a073aec627162d918b84e4e20c03 100644

--- a/android_webview/java/src/org/chromium/android_webview/AwSettings.java

+++ b/android_webview/java/src/org/chromium/android_webview/AwSettings.java

@@ -262,8 +262,7 @@ public class AwSettings {

void setDIPScale(double dipScale) {

synchronized (mAwSettingsLock) {

mDIPScale = dipScale;

- // TODO(joth): This should also be synced over to native side, but right now

- // the setDIPScale call is always followed by a setWebContents() which covers this.

+ if (mNativeAwSettings != 0) updateEverythingLocked();

}