API to provide status of save page reqeusts to API.

components/offline_pages/background/request_coordinator.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/offline_pages/background/request_coordinator.h"
 
 #include <utility>
 
 #include "base/bind.h"
 #include "base/callback.h"
@@ skipping 51 matching lines @@
   // Build a SavePageRequest.
   offline_pages::SavePageRequest request(
       id++, url, client_id, base::Time::Now(), was_user_requested);
 
   // Put the request on the request queue.
   queue_->AddRequest(request,
                      base::Bind(&RequestCoordinator::AddRequestResultCallback,
                                 weak_ptr_factory_.GetWeakPtr()));
   return true;
 }
+void RequestCoordinator::GetQueuedRequests(
+    const std::string& client_namespace,
+    const QueuedRequestCallback& callback) {
+  // Get all matching requests from the request queue, send them to our
+  // callback.  We bind the namespace and callback to the front of the callback
+  // param set.
+  queue_->GetRequests(base::Bind(&RequestCoordinator::GetQueuedRequestsCallback,
+                                 weak_ptr_factory_.GetWeakPtr(),
+                                 client_namespace, callback));
+}
+
+// For each request matching the client_namespace, return the ClientId.
+void RequestCoordinator::GetQueuedRequestsCallback(
+    const std::string& client_namespace,
+    QueuedRequestCallback callback,
+    RequestQueue::GetRequestsResult result,
+    const std::vector<SavePageRequest>& requests) {
+  std::vector<ClientId> found_requests;

[fgorski, 2016/08/03 03:13:15]

Consider renaming to client_ids.

[Pete Williamson, 2016/08/03 20:13:44]

Done.

+
+  // TODO(petewil): Is find_if better that a for loop here?

[fgorski, 2016/08/03 03:13:15]

no, it would be incorrect, because:
find_if returns the first element in the range [first, last) that satisfies
specific criteria.
Following: http://en.cppreference.com/w/cpp/algorithm/find

Please remove the TODO.

Also, copy_if would not work, and for_each is not reasonable here. I think you
have the right solution.

[Pete Williamson, 2016/08/03 20:13:44]

Acknowledged.

+  for (auto iter = requests.begin(); iter != requests.end(); ++iter) {
+    if (client_namespace == iter->client_id().name_space) {

[fgorski, 2016/08/03 03:13:15]

nit: remove {}

[Pete Williamson, 2016/08/03 20:13:44]

Done.

+      found_requests.push_back(iter->client_id());
+    }
+  }
+
+  callback.Run(found_requests);
+}
 
 void RequestCoordinator::AddRequestResultCallback(
     RequestQueue::AddRequestResult result,
     const SavePageRequest& request) {
 
   // Inform the scheduler that we have an outstanding task..
   scheduler_->Schedule(GetTriggerConditionsForUserRequest());
 }
 
 // Called in response to updating a request in the request queue.
@@ skipping 158 matching lines @@
   return trigger_conditions;
 }
 
 void RequestCoordinator::GetOffliner() {
   if (!offliner_) {
     offliner_ = factory_->GetOffliner(policy_.get());
   }
 }
 
 }  // namespace offline_pages