API to provide status of save page reqeusts to API.

components/offline_pages/background/request_status.h

+// Copyright 2016 The Chromium Authors. All rights reserved.

[Pete Williamson, 2016/08/03 00:24:32]

Removing this whole file, we will use ClientIds instead.

+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_OFFLINE_PAGES_BACKGROUND_REQUEST_STATUS_H_
+#define COMPONENTS_OFFLINE_PAGES_BACKGROUND_REQUEST_STATUS_H_
+
+#include <string>
+
+#include "components/offline_pages/background/save_page_request.h"
+
+namespace offline_pages {
+
+  struct RequestStatus {
+    std::string client_id;

[fgorski, 2016/08/02 04:18:12]

why not a ClientId? you will get partial information from this and this approach
precludes the struct from being used in a more generic queries.

[Pete Williamson, 2016/08/03 00:24:32]

The idea was that the client already knows the namespace (since they had to
supply it with the request to get statuses), so we only need to give them the id
within their namespace.

+    SavePageRequest::Status status;

[dougarnett, 2016/08/02 20:39:28]

Later, we may end up wanting to move this Status enum out of SavePageRequest.

[Pete Williamson, 2016/08/03 00:24:32]

File deleted

+    // TODO(petewil): We can easily add the URL, would it help?

[dougarnett, 2016/08/02 20:39:28]

Seems like a good thing to include although don't have strong use case (might
depend on how ClientIds are constructed by client (if they have any real
information or not))

[Pete Williamson, 2016/08/03 00:24:32]

File deleted

+
+    RequestStatus(std::string id, SavePageRequest::Status request_status)

[fgorski, 2016/08/02 04:18:12]

const & for id.

[Pete Williamson, 2016/08/03 00:24:32]

File deleted

+      : client_id(id), status(request_status) {}
+
+        };

[fgorski, 2016/08/02 04:18:12]

nit: git cl format, which will solve a few issues in this file.

[Pete Williamson, 2016/08/03 00:24:32]

Done.  Generally I'm not a fan of git cl format, while it fixes these issues, it
does the indentation in a way that I don't prefer, I think it chooses a less
readable of the allowed options.
If you ask for it, I'll run it, but I will likely just fix things up by hand
otherwise.

+
+}  // namespace offline_pages
+

[fgorski, 2016/08/02 04:18:12]

nit: remove extra line.

[Pete Williamson, 2016/08/03 00:24:32]

Done.

+
+#endif // COMPONENTS_OFFLINE_PAGES_BACKGROUND_REQUEST_STATUS_H_