Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Side by Side Diff: components/offline_pages/background/request_queue.cc

Issue 2202113002: API to provide status of save page reqeusts to API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/offline_pages/background/request_queue.h" 5 #include "components/offline_pages/background/request_queue.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/location.h" 8 #include "base/location.h"
9 #include "base/threading/thread_task_runner_handle.h" 9 #include "base/threading/thread_task_runner_handle.h"
10 #include "components/offline_pages/background/request_queue_store.h" 10 #include "components/offline_pages/background/request_queue_store.h"
11 #include "components/offline_pages/background/save_page_request.h" 11 #include "components/offline_pages/background/save_page_request.h"
12 12
13 namespace offline_pages { 13 namespace offline_pages {
14 14
15 namespace { 15 namespace {
16 // Completes the get requests call. 16 // Completes the get requests call.
17 void GetRequestsDone(const RequestQueue::GetRequestsCallback& callback, 17 void GetRequestsDone(const RequestQueue::GetRequestsCallback& callback,
18 bool success, 18 bool success,
19 const std::vector<SavePageRequest>& requests) { 19 const std::vector<SavePageRequest>& requests) {
20 DVLOG(0) << "@@@@@@ " << __func__;
fgorski 2016/08/02 04:18:12 nit: do you need to keep these?
Pete Williamson 2016/08/03 00:24:32 Nope, leftover from debugging. I must have missed
20 RequestQueue::GetRequestsResult result = 21 RequestQueue::GetRequestsResult result =
21 success ? RequestQueue::GetRequestsResult::SUCCESS 22 success ? RequestQueue::GetRequestsResult::SUCCESS
22 : RequestQueue::GetRequestsResult::STORE_FAILURE; 23 : RequestQueue::GetRequestsResult::STORE_FAILURE;
23 // TODO(fgorski): Filter out expired requests based on policy. 24 // TODO(fgorski): Filter out expired requests based on policy.
24 // This may trigger the purging if necessary. 25 // This may trigger the purging if necessary.
25 // Also this may be turned into a method on the request queue or add a policy 26 // Also this may be turned into a method on the request queue or add a policy
26 // parameter in the process. 27 // parameter in the process.
27 callback.Run(result, requests); 28 callback.Run(result, requests);
28 } 29 }
29 30
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
61 } 62 }
62 63
63 } // namespace 64 } // namespace
64 65
65 RequestQueue::RequestQueue(std::unique_ptr<RequestQueueStore> store) 66 RequestQueue::RequestQueue(std::unique_ptr<RequestQueueStore> store)
66 : store_(std::move(store)), weak_ptr_factory_(this) {} 67 : store_(std::move(store)), weak_ptr_factory_(this) {}
67 68
68 RequestQueue::~RequestQueue() {} 69 RequestQueue::~RequestQueue() {}
69 70
70 void RequestQueue::GetRequests(const GetRequestsCallback& callback) { 71 void RequestQueue::GetRequests(const GetRequestsCallback& callback) {
72 DVLOG(0) << "@@@@@@ " << __func__;
71 store_->GetRequests(base::Bind(&GetRequestsDone, callback)); 73 store_->GetRequests(base::Bind(&GetRequestsDone, callback));
72 } 74 }
73 75
74 void RequestQueue::AddRequest(const SavePageRequest& request, 76 void RequestQueue::AddRequest(const SavePageRequest& request,
75 const AddRequestCallback& callback) { 77 const AddRequestCallback& callback) {
76 // TODO(fgorski): check that request makes sense. 78 // TODO(fgorski): check that request makes sense.
77 // TODO(fgorski): check that request does not violate policy. 79 // TODO(fgorski): check that request does not violate policy.
78 store_->AddOrUpdateRequest(request, 80 store_->AddOrUpdateRequest(request,
79 base::Bind(&AddRequestDone, callback, request)); 81 base::Bind(&AddRequestDone, callback, request));
80 } 82 }
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
131 133
132 void RequestQueue::RemoveRequest(int64_t request_id, 134 void RequestQueue::RemoveRequest(int64_t request_id,
133 const UpdateRequestCallback& callback) { 135 const UpdateRequestCallback& callback) {
134 std::vector<int64_t> request_ids{request_id}; 136 std::vector<int64_t> request_ids{request_id};
135 store_->RemoveRequests(request_ids, base::Bind(RemoveRequestDone, callback)); 137 store_->RemoveRequests(request_ids, base::Bind(RemoveRequestDone, callback));
136 } 138 }
137 139
138 void RequestQueue::PurgeRequests(const PurgeRequestsCallback& callback) {} 140 void RequestQueue::PurgeRequests(const PurgeRequestsCallback& callback) {}
139 141
140 } // namespace offline_pages 142 } // namespace offline_pages
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698