core/fpdfdoc/cpvt_generateap.cpp - Issue 2202063002: Support PDF highlight annotation with opacity.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfdoc/cpvt_generateap.cpp

Issue 2202063002: Support PDF highlight annotation with opacity. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfdoc/cpvt_generateap.cpp

diff --git a/core/fpdfdoc/cpvt_generateap.cpp b/core/fpdfdoc/cpvt_generateap.cpp

index 56b661271702cb5e3f6ad2c75f6ccad1b58d056a..8f68631a7301c7d827a971096a7ce5520a39f15f 100644

--- a/core/fpdfdoc/cpvt_generateap.cpp

+++ b/core/fpdfdoc/cpvt_generateap.cpp

@@ -538,8 +538,10 @@ bool CPVT_GenerateAP::GenerateHighlightAP(CPDF_Document* pDoc,

CPDF_Dictionary* pGSDict = new CPDF_Dictionary;

pGSDict->SetAtString("Type", "ExtGState");

- pGSDict->SetAtNumber("ca", 1);

- pGSDict->SetAtNumber("CA", 1);

+ FX_FLOAT fCA = pAnnotDict->KeyExist("CA") ? pAnnotDict->GetNumberBy("CA") : 1;

Lei Zhang 2016/08/01 23:50:48 How about naming the variable "fStrokeAlpha" ?

jaepark 2016/08/02 00:21:54 Done. Changed it to fOpacity.

+ pGSDict->SetAtNumber("ca", fCA);

+ pGSDict->SetAtNumber("CA", fCA);

pGSDict->SetAtBoolean("AIS", false);

pGSDict->SetAtString("BM", "Multiply");

« no previous file with comments | « no previous file | no next file » | no next file with comments »