Support PDF highlight annotation with opacity.

Support PDF highlight annotation with opacity.

BUG=62625
Committed: https://pdfium.googlesource.com/pdfium/+/2d7ab183976259dd9f428bfe3e10966fdd3e5f65

[jaepark, 2016-08-01 23:44:17]

jaepark@google.com changed reviewers:
+ thestig@chromium.org

[jaepark, 2016-08-01 23:44:17]

This patch should be committed after adding a test case in testing/corpus and
with DEPS rolled.

[jaepark, 2016-08-01 23:44:30]

Description was changed from

==========
Support PDF highlight annotation with opacity.

BUG=62625
==========

to

==========
Support PDF highlight annotation with opacity.

BUG=62625
==========

[Lei Zhang, 2016-08-01 23:47:43]

On 2016/08/01 23:44:17, jaepark wrote:
> This patch should be committed after adding a test case in testing/corpus and
> with DEPS rolled.

Ok. Looking forward to the test case.

[Lei Zhang, 2016-08-01 23:50:48]

https://codereview.chromium.org/2202063002/diff/1/core/fpdfdoc/cpvt_generatea...
File core/fpdfdoc/cpvt_generateap.cpp (right):

https://codereview.chromium.org/2202063002/diff/1/core/fpdfdoc/cpvt_generatea...
core/fpdfdoc/cpvt_generateap.cpp:542: FX_FLOAT fCA = pAnnotDict->KeyExist("CA")
? pAnnotDict->GetNumberBy("CA") : 1;
How about naming the variable "fStrokeAlpha" ?

[jaepark, 2016-08-01 23:57:54]

On 2016/08/01 23:50:48, Lei Zhang wrote:
>
https://codereview.chromium.org/2202063002/diff/1/core/fpdfdoc/cpvt_generatea...
> File core/fpdfdoc/cpvt_generateap.cpp (right):
> 
>
https://codereview.chromium.org/2202063002/diff/1/core/fpdfdoc/cpvt_generatea...
> core/fpdfdoc/cpvt_generateap.cpp:542: FX_FLOAT fCA =
pAnnotDict->KeyExist("CA")
> ? pAnnotDict->GetNumberBy("CA") : 1;
> How about naming the variable "fStrokeAlpha" ?

This value is used for both stroke and fill opacity, so I don't think
fStrokeAlpha is quite accurate.
How about fOpacity?

[Lei Zhang, 2016-08-02 00:00:00]

On 2016/08/01 23:57:54, jaepark wrote:
> On 2016/08/01 23:50:48, Lei Zhang wrote:
> >
>
https://codereview.chromium.org/2202063002/diff/1/core/fpdfdoc/cpvt_generatea...
> > File core/fpdfdoc/cpvt_generateap.cpp (right):
> > 
> >
>
https://codereview.chromium.org/2202063002/diff/1/core/fpdfdoc/cpvt_generatea...
> > core/fpdfdoc/cpvt_generateap.cpp:542: FX_FLOAT fCA =
> pAnnotDict->KeyExist("CA")
> > ? pAnnotDict->GetNumberBy("CA") : 1;
> > How about naming the variable "fStrokeAlpha" ?
> 
> This value is used for both stroke and fill opacity, so I don't think
> fStrokeAlpha is quite accurate.
> How about fOpacity?

Sure. Knowing what "CA" means involves pulling out the PDF spec. Let's avoid
that.

[jaepark, 2016-08-02 00:21:54]

https://codereview.chromium.org/2202063002/diff/1/core/fpdfdoc/cpvt_generatea...
File core/fpdfdoc/cpvt_generateap.cpp (right):

https://codereview.chromium.org/2202063002/diff/1/core/fpdfdoc/cpvt_generatea...
core/fpdfdoc/cpvt_generateap.cpp:542: FX_FLOAT fCA = pAnnotDict->KeyExist("CA")
? pAnnotDict->GetNumberBy("CA") : 1;
On 2016/08/01 23:50:48, Lei Zhang wrote:
> How about naming the variable "fStrokeAlpha" ?

Done. Changed it to fOpacity.

[jaepark, 2016-08-02 00:39:24]

Roll DEPS for testing/corpus to test highlight annotation with opacity
(https://codereview.chromium.org/2204763002/).

[Lei Zhang, 2016-08-02 00:41:43]

lgtm

[jaepark, 2016-08-02 00:42:38]

The CQ bit was checked by jaepark@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-02 00:42:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-02 01:00:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-02 01:00:39]

Dry run: This issue passed the CQ dry run.

[jaepark, 2016-08-02 01:06:58]

The CQ bit was checked by jaepark@google.com

[commit-bot: I haz the power, 2016-08-02 01:07:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-02 01:07:29]

Description was changed from

==========
Support PDF highlight annotation with opacity.

BUG=62625
==========

to

==========
Support PDF highlight annotation with opacity.

BUG=62625

Committed:
https://pdfium.googlesource.com/pdfium/+/2d7ab183976259dd9f428bfe3e10966fdd3e...
==========

[commit-bot: I haz the power, 2016-08-02 01:07:30]

Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/2d7ab183976259dd9f428bfe3e10966fdd3e...