headless: Add a test for sending cookies from a protocol handler

headless: Add a test for sending cookies from a protocol handler

This patch adds a test for sending outgoing cookies from a protocol
handler. The cookies are read asynchronously from the cookie store
associated with the request.

BUG=546953
Committed: https://crrev.com/7b6f78f23894ab0eb24eb6ad56d58b61319f8746
Cr-Commit-Position: refs/heads/master@{#409490}

[Sami, 2016-08-02 17:46:35]

Description was changed from

==========
headless: Add a test for sending cookies from a protocol handler

This patch adds a test for sending outgoing cookies from a protocol
handler. The cookies are read asynchronously from the cookie store
associated with the request.

BUG=546953
==========

to

==========
headless: Add a test for sending cookies from a protocol handler

This patch adds a test for sending outgoing cookies from a protocol
handler. The cookies are read asynchronously from the cookie store
associated with the request.

BUG=546953
==========

[Sami, 2016-08-02 17:46:35]

skyostil@chromium.org changed reviewers:
+ eseckler@chromium.org

[Sami, 2016-08-02 17:47:17]

Turns out we already have all the pieces we need for computing outgoing cookies.
I wanted to add a test to make sure it stays that way. PTAL.

[Eric Seckler, 2016-08-02 19:50:47]

lgtm with a tiny nit.

yay to cookies! :)

https://codereview.chromium.org/2202053007/diff/1/headless/lib/headless_brows...
File headless/lib/headless_browser_browsertest.cc (right):

https://codereview.chromium.org/2202053007/diff/1/headless/lib/headless_brows...
headless/lib/headless_browser_browsertest.cc:291:
.SetInitialURL(GURL("https://example.com/cookie.html"))
Nit: I'd change this to a fictive domain to indicate that we don't actually go
and fetch example.com.

[Sami, 2016-08-03 09:55:58]

https://codereview.chromium.org/2202053007/diff/1/headless/lib/headless_brows...
File headless/lib/headless_browser_browsertest.cc (right):

https://codereview.chromium.org/2202053007/diff/1/headless/lib/headless_brows...
headless/lib/headless_browser_browsertest.cc:291:
.SetInitialURL(GURL("https://example.com/cookie.html"))
On 2016/08/02 19:50:47, Eric Seckler wrote:
> Nit: I'd change this to a fictive domain to indicate that we don't actually go
> and fetch http://example.com.

Actually that's exactly what example.com is :) http://example.com says: "This
domain is established to be used for illustrative examples in documents."

See also http://www.iana.org/domains/reserved.

[Sami, 2016-08-03 10:58:07]

The CQ bit was checked by skyostil@chromium.org

[commit-bot: I haz the power, 2016-08-03 10:58:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Eric Seckler, 2016-08-03 10:58:31]

lgtm

[commit-bot: I haz the power, 2016-08-03 11:43:20]

Description was changed from

==========
headless: Add a test for sending cookies from a protocol handler

This patch adds a test for sending outgoing cookies from a protocol
handler. The cookies are read asynchronously from the cookie store
associated with the request.

BUG=546953
==========

to

==========
headless: Add a test for sending cookies from a protocol handler

This patch adds a test for sending outgoing cookies from a protocol
handler. The cookies are read asynchronously from the cookie store
associated with the request.

BUG=546953
==========

[commit-bot: I haz the power, 2016-08-03 11:43:22]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-03 11:45:14]

Description was changed from

==========
headless: Add a test for sending cookies from a protocol handler

This patch adds a test for sending outgoing cookies from a protocol
handler. The cookies are read asynchronously from the cookie store
associated with the request.

BUG=546953
==========

to

==========
headless: Add a test for sending cookies from a protocol handler

This patch adds a test for sending outgoing cookies from a protocol
handler. The cookies are read asynchronously from the cookie store
associated with the request.

BUG=546953

Committed: https://crrev.com/7b6f78f23894ab0eb24eb6ad56d58b61319f8746
Cr-Commit-Position: refs/heads/master@{#409490}
==========

[commit-bot: I haz the power, 2016-08-03 11:45:15]

Patchset 1 (id:??) landed as
https://crrev.com/7b6f78f23894ab0eb24eb6ad56d58b61319f8746
Cr-Commit-Position: refs/heads/master@{#409490}