More fixes for SwarmBucket

infra/bots/recipe_modules/skia_swarming/api.py

Index: infra/bots/recipe_modules/skia_swarming/api.py
diff --git a/infra/bots/recipe_modules/skia_swarming/api.py b/infra/bots/recipe_modules/skia_swarming/api.py
index 6993b9de41590b65e45482c98574907afecc14af..db06826a3ea3133cf476c916a15f799fa6541a65 100644
--- a/infra/bots/recipe_modules/skia_swarming/api.py
+++ b/infra/bots/recipe_modules/skia_swarming/api.py
@@ -41,18 +41,24 @@ class SkiaSwarmingApi(recipe_api.RecipeApi):
   # TODO(rmistry): Remove once the Go binaries are moved to recipes or buildbot.
   def setup_go_isolate(self, luci_go_dir):
     """Generates and puts in place the isolate Go binary."""
+    depot_tools_path = self.m.depot_tools.package_repo_resource()
+    env = {'PATH': self.m.path.pathsep.join([
+        str(depot_tools_path), '%(PATH)s'])}

[rmistry, 2016/08/02 13:25:52]

Nit: Could you indent this line starting with the line above it, i.e:

env = {'PATH': self.m.path.pathsep.join([
                   str(depot_tools_path), '%(PATH)s'])}

Will make it slightly more readable.

[borenet, 2016/08/02 13:27:08]

Done.

     self.m.step('download luci-go linux',
                 ['download_from_google_storage', '--no_resume',
                  '--platform=linux*', '--no_auth', '--bucket', 'chromium-luci',
-                 '-d', luci_go_dir.join('linux64')])
+                 '-d', luci_go_dir.join('linux64')],
+                env=env)
     self.m.step('download luci-go mac',
                 ['download_from_google_storage', '--no_resume',
                  '--platform=darwin', '--no_auth', '--bucket', 'chromium-luci',
-                 '-d', luci_go_dir.join('mac64')])
+                 '-d', luci_go_dir.join('mac64')],
+                env=env)
     self.m.step('download luci-go win',
                 ['download_from_google_storage', '--no_resume',
                  '--platform=win32', '--no_auth', '--bucket', 'chromium-luci',
-                 '-d', luci_go_dir.join('win64')])
+                 '-d', luci_go_dir.join('win64')],
+                env=env)
     # Copy binaries to the expected location.
     dest = self.m.path['slave_build'].join('luci-go')
     self.m.skia.rmtree(dest)