More fixes for SwarmBucket

More fixes for SwarmBucket

BUG=skia:5581
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2202053005
NOTRY=true

Committed: https://skia.googlesource.com/skia/+/ed696276fd5b7cd995e7e75d6c579f16d28bd36a

[borenet2, 2016-08-02 12:36:13]

Description was changed from

==========
More fixes for SwarmBucket

BUG=skia:5581
==========

to

==========
More fixes for SwarmBucket

BUG=skia:5581
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2202053005
==========

[borenet, 2016-08-02 12:38:31]

borenet@google.com changed reviewers:
+ borenet@google.com, rmistry@google.com

[rmistry, 2016-08-02 13:25:53]

lgtm

https://codereview.chromium.org/2202053005/diff/1/infra/bots/recipe_modules/s...
File infra/bots/recipe_modules/skia_swarming/api.py (right):

https://codereview.chromium.org/2202053005/diff/1/infra/bots/recipe_modules/s...
infra/bots/recipe_modules/skia_swarming/api.py:46: str(depot_tools_path),
'%(PATH)s'])}
Nit: Could you indent this line starting with the line above it, i.e:

env = {'PATH': self.m.path.pathsep.join([
                   str(depot_tools_path), '%(PATH)s'])}

Will make it slightly more readable.

[borenet, 2016-08-02 13:27:08]

https://codereview.chromium.org/2202053005/diff/1/infra/bots/recipe_modules/s...
File infra/bots/recipe_modules/skia_swarming/api.py (right):

https://codereview.chromium.org/2202053005/diff/1/infra/bots/recipe_modules/s...
infra/bots/recipe_modules/skia_swarming/api.py:46: str(depot_tools_path),
'%(PATH)s'])}
On 2016/08/02 13:25:52, rmistry wrote:
> Nit: Could you indent this line starting with the line above it, i.e:
> 
> env = {'PATH': self.m.path.pathsep.join([
>                    str(depot_tools_path), '%(PATH)s'])}
> 
> Will make it slightly more readable.

Done.

[borenet, 2016-08-02 13:27:15]

The CQ bit was checked by borenet@google.com

[borenet, 2016-08-02 13:27:16]

The patchset sent to the CQ was uploaded after l-g-t-m from rmistry@google.com
Link to the patchset: https://codereview.chromium.org/2202053005/#ps20001
(title: "Address comment")

[commit-bot: I haz the power, 2016-08-02 13:27:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[borenet, 2016-08-02 13:49:43]

Description was changed from

==========
More fixes for SwarmBucket

BUG=skia:5581
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2202053005
==========

to

==========
More fixes for SwarmBucket

BUG=skia:5581
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2202053005
NOTRY=true
==========

[borenet, 2016-08-02 13:49:48]

The CQ bit was unchecked by borenet@google.com

[borenet, 2016-08-02 13:49:52]

The CQ bit was checked by borenet@google.com

[commit-bot: I haz the power, 2016-08-02 13:50:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-02 13:50:54]

Description was changed from

==========
More fixes for SwarmBucket

BUG=skia:5581
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2202053005
NOTRY=true
==========

to

==========
More fixes for SwarmBucket

BUG=skia:5581
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2202053005
NOTRY=true

Committed:
https://skia.googlesource.com/skia/+/ed696276fd5b7cd995e7e75d6c579f16d28bd36a
==========

[commit-bot: I haz the power, 2016-08-02 13:50:56]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/ed696276fd5b7cd995e7e75d6c579f16d28bd36a