Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Unified Diff: experimental/svg/model/SkSVGTypes.h

Issue 2202053002: [SVGDom/experimental] Initial SVGLength support (Closed) Base URL: https://chromium.googlesource.com/skia.git@master
Patch Set: cleanup Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: experimental/svg/model/SkSVGTypes.h
diff --git a/experimental/svg/model/SkSVGTypes.h b/experimental/svg/model/SkSVGTypes.h
new file mode 100644
index 0000000000000000000000000000000000000000..f9123ef451f5128a9bafb2b4df0899691f493b5f
--- /dev/null
+++ b/experimental/svg/model/SkSVGTypes.h
@@ -0,0 +1,77 @@
+/*
+ * Copyright 2016 Google Inc.
+ *
+ * Use of this source code is governed by a BSD-style license that can be
+ * found in the LICENSE file.
+ */
+
+#ifndef SkSVGTypes_DEFINED
+#define SkSVGTypes_DEFINED
+
+#include "SkColor.h"
+#include "SkScalar.h"
+#include "SkTypes.h"
+
+class SkSVGNumber {
+public:
robertphillips 2016/08/02 22:25:56 Make these two one line each ?
f(malita) 2016/08/03 16:50:52 Done.
+ constexpr SkSVGNumber()
+ : fValue(0) {}
+ explicit constexpr SkSVGNumber(SkScalar v)
+ : fValue(v) {}
+ SkSVGNumber(const SkSVGNumber&) = default;
+ SkSVGNumber& operator=(const SkSVGNumber&) = default;
+
+
+ const SkScalar& value() const { return fValue; }
+
+ operator const SkScalar&() const { return fValue; }
+
+private:
+ SkScalar fValue;
+};
+
+class SkSVGLength {
+public:
+ enum class Unit {
+ kUnknown,
+ kNumber,
+ kPercentage,
+ kEMS,
+ kEXS,
+ kPX,
+ kCM,
+ kMM,
+ kIN,
+ kPT,
+ kPC,
+ };
+
robertphillips 2016/08/02 22:25:56 single line this guy ?
f(malita) 2016/08/03 16:50:52 Done.
+ constexpr SkSVGLength()
+ : fValue(0), fUnit(Unit::kUnknown) {}
+ explicit constexpr SkSVGLength(SkScalar v, Unit u = Unit::kNumber)
+ : fValue(v), fUnit(u) {}
+ SkSVGLength(const SkSVGLength&) = default;
+ SkSVGLength& operator=(const SkSVGLength&) = default;
+
+ const SkScalar& value() const { return fValue; }
+ const Unit& unit() const { return fUnit; }
+
+private:
+ SkScalar fValue;
+ Unit fUnit;
+};
+
+class SkSVGColor {
+public:
robertphillips 2016/08/02 22:25:56 single lines ?
f(malita) 2016/08/03 16:50:52 Done.
+ constexpr SkSVGColor()
+ : fValue(SK_ColorBLACK) {}
+ explicit constexpr SkSVGColor(SkColor c)
+ : fValue(c) {}
+
+ operator const SkColor&() const { return fValue; }
+
+private:
+ SkColor fValue;
+};
+
+#endif // SkSVGTypes_DEFINED

Powered by Google App Engine
This is Rietveld 408576698