Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1161)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/input/PopupTouchHandleDrawable.java

Issue 2202043002: [Merge m52] android: Swallow PopupWindow exception from android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2743
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/android/java/src/org/chromium/content/browser/input/PopupTouchHandleDrawable.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/input/PopupTouchHandleDrawable.java b/content/public/android/java/src/org/chromium/content/browser/input/PopupTouchHandleDrawable.java
index 52cfd8f6847483d3b5a8015d22e1063451224860..dce0644ca968d5776a59fb724a9aae67b72a5d2a 100644
--- a/content/public/android/java/src/org/chromium/content/browser/input/PopupTouchHandleDrawable.java
+++ b/content/public/android/java/src/org/chromium/content/browser/input/PopupTouchHandleDrawable.java
@@ -464,7 +464,13 @@ public class PopupTouchHandleDrawable extends View {
mTemporarilyHiddenExpireTime = 0;
setTemporarilyHidden(false);
mAlpha = 1.0f;
- if (mContainer.isShowing()) mContainer.dismiss();
+ if (mContainer.isShowing()) {
+ try {
+ mContainer.dismiss();
+ } catch (IllegalArgumentException e) {
+ // Intentionally swallowed due to bad Android implemention. See crbug.com/633224.
+ }
+ }
mParentPositionObserver.clearListener();
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698