Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Issue 2202033003: Reland of Disable NV12 texture sharing with VP9 hardware video decoding. (Closed)

Created:
4 years, 4 months ago by Guido Urdaneta
Modified:
4 years, 4 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, piman+watch_chromium.org, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Disable NV12 texture sharing with VP9 hardware video decoding. (patchset #1 id:1 of https://codereview.chromium.org/2200963003/ ) Reason for revert: This revert did not fix the issue it was suspect of causing. Original issue's description: > Revert of Disable NV12 texture sharing with VP9 hardware video decoding. (patchset #1 id:1 of https://codereview.chromium.org/2188423002/ ) > > Reason for revert: > Speculative revert to see if this is the cause of WebRTC Windows bot breakage. See crbug.com/633519 > > Will reland if the revert does not fix the problem. > > Original issue's description: > > Disable NV12 texture sharing with VP9 hardware video decoding. > > > > The Microsoft MFT we're using doesn't pass through the bind flags > > correctly so sharing textures with ANGLE doesn't work. > > > > Committed: https://crrev.com/5ad89d562b0e49fc0427722eb48bf3852fae6e9c > > Cr-Commit-Position: refs/heads/master@{#408791} > > TBR=sandersd@chromium.org,jbauman@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > > Committed: https://crrev.com/8e1bf222a21b526edfdafc2ab7ade4dc3f7dca84 > Cr-Commit-Position: refs/heads/master@{#409164} TBR=sandersd@chromium.org,jbauman@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/bd942ced3f3790dc540e9390c2a6c24b64aae4dc Cr-Commit-Position: refs/heads/master@{#409174}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M media/gpu/dxva_video_decode_accelerator_win.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Guido Urdaneta
Created Reland of Disable NV12 texture sharing with VP9 hardware video decoding.
4 years, 4 months ago (2016-08-02 12:04:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2202033003/1
4 years, 4 months ago (2016-08-02 12:04:49 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-02 12:05:35 UTC) #4
commit-bot: I haz the power
4 years, 4 months ago (2016-08-02 12:07:29 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bd942ced3f3790dc540e9390c2a6c24b64aae4dc
Cr-Commit-Position: refs/heads/master@{#409174}

Powered by Google App Engine
This is Rietveld 408576698