Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 220203012: ARM64: Fix the atomic type width in the 64bit Acquire_Load(). (Closed)

Created:
6 years, 8 months ago by Alexandre Rames
Modified:
6 years, 8 months ago
CC:
v8-dev
Visibility:
Public.

Description

ARM64: Fix the atomic type width in the 64bit Acquire_Load(). R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20486

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/atomicops_internals_arm64_gcc.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Alexandre Rames
6 years, 8 months ago (2014-04-03 12:50:40 UTC) #1
ulan
lgtm
6 years, 8 months ago (2014-04-03 13:19:45 UTC) #2
Alexandre Rames
Committed patchset #1 manually as r20486 (presubmit successful).
6 years, 8 months ago (2014-04-03 14:28:47 UTC) #3
rmcilroy
On 2014/04/03 14:28:47, Alexandre Rames wrote: > Committed patchset #1 manually as r20486 (presubmit successful). ...
6 years, 8 months ago (2014-04-17 12:33:56 UTC) #4
ulan
On 2014/04/17 12:33:56, rmcilroy wrote: > On 2014/04/03 14:28:47, Alexandre Rames wrote: > > Committed ...
6 years, 8 months ago (2014-04-17 12:38:34 UTC) #5
Alexandre Rames
6 years, 8 months ago (2014-04-17 13:08:21 UTC) #6
Message was sent while issue was closed.
On 2014/04/17 12:33:56, rmcilroy wrote:
> On 2014/04/03 14:28:47, Alexandre Rames wrote:
> > Committed patchset #1 manually as r20486 (presubmit successful).
> 
> Could you let me know if you fix any bugs in atomicops_internals_arm64_gcc.h
in
> the future so that I can include the fix in Chrome's base/ implementation.  I
> just spent quite a while debugging a crash in Chrome which turned out to be
due
> to this bug, but I didn't know you'd already fixed in V8.

Ouch. Sorry about that. I will keep it in mind.

Powered by Google App Engine
This is Rietveld 408576698