Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1114)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 220203007: DevTools: fix primary selection in multiple selections created with ctrl-d (Closed)

Created:
6 years, 8 months ago by lushnikov
Modified:
6 years, 8 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

DevTools: fix primary selection in multiple selections created with ctrl-d This patch sets correct index to the multiple selections created with ctrl-d. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170643

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M Source/devtools/front_end/CodeMirrorTextEditor.js View 4 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
lushnikov
please take a look
6 years, 8 months ago (2014-04-01 17:35:03 UTC) #1
pfeldman
lgtm
6 years, 8 months ago (2014-04-01 17:36:02 UTC) #2
lushnikov
The CQ bit was checked by lushnikov@chromium.org
6 years, 8 months ago (2014-04-01 17:59:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/220203007/1
6 years, 8 months ago (2014-04-01 18:01:21 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-01 18:30:03 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_compile_dbg
6 years, 8 months ago (2014-04-01 18:30:03 UTC) #6
lushnikov
The CQ bit was checked by lushnikov@chromium.org
6 years, 8 months ago (2014-04-02 08:30:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/220203007/1
6 years, 8 months ago (2014-04-02 08:30:56 UTC) #8
commit-bot: I haz the power
6 years, 8 months ago (2014-04-02 09:06:33 UTC) #9
Message was sent while issue was closed. 
Change committed as 170643

Powered by Google App Engine
This is Rietveld 408576698