LayoutTests/fast/forms/associatedFormControls-leak-nodes.html - Issue 220203005: Oilpan: introduce sticky forcedForTesting flag to ensure that a precise

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/forms/associatedFormControls-leak-nodes.html

Issue 220203005: Oilpan: introduce sticky forcedForTesting flag to ensure that a precise (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <body>	3 <body>

4 <iframe id="frame"></iframe>	4 <iframe id="frame"></iframe>

5	5

6 <script src="../../resources/js-test.js"></script>	6 <script src="../../resources/js-test.js"></script>

7 <script>	7 <script>

8 if (!window.internals) {	8 if (!window.internals) {

9 debug("This test only runs on \"content_shell --dump-render-tree\", as it re quires existence of window.internals.");	9 debug("This test only runs on \"content_shell --dump-render-tree\", as it re quires existence of window.internals.");

10 } else {	10 } else {

11 gc();	11 testRunner.waitUntilDone();
	wibling-chromium 2014/04/01 13:26:09 Can't we wait at the end to ensure we don't exit t Can't we wait at the end to ensure we don't exit the test until done? Mads Ager (chromium) 2014/04/01 13:45:38 This is setting a flag in the test runner that thi Show quoted text On 2014/04/01 13:26:09, wibling-chromium wrote: > Can't we wait at the end to ensure we don't exit the test until done? This is setting a flag in the test runner that this test is not done until it calls notifyDone and it is usually done in the beginning of the test. The only thing that matters is that it is called synchronously here. Otherwise the layout test will exit without going back to the event loop. So, it could be at the end of this straight-line code, but the usual placement is at the top so I'll leave it there.
12 var documentsBefore = window.internals.numberOfLiveDocuments();	12 var documentsBefore;

	13 var documentsAfter;

	14 collectGarbage(function() {

	15 documentsBefore = window.internals.numberOfLiveDocuments();

13	16

14 var frame = document.getElementById('frame');	17 var frame = document.getElementById('frame');

15 frame.contentDocument.body.innerHTML = '<form></form>';	18 frame.contentDocument.body.innerHTML = '<form></form>';

16 document.body.removeChild(frame);	19 document.body.removeChild(frame);

17 frame = null;	20 frame = null;

18	21

19 gc();	22 collectGarbage(function() {

20 var documentsAfter = window.internals.numberOfLiveDocuments();	23 documentsAfter = window.internals.numberOfLiveDocuments();

21	24

22 // -1 is from removing frame itself.	25 // -1 is from removing frame itself.

23 shouldBe('documentsBefore - 1', 'documentsAfter');	26 shouldBe('documentsBefore - 1', 'documentsAfter');

	27 testRunner.notifyDone();

	28 });

	29 });

24 }	30 }

25 </script>	31 </script>

26 </body>	32 </body>

27 </html>	33 </html>

OLD	NEW

« no previous file with comments | « LayoutTests/OilpanExpectations ('k') | LayoutTests/resources/js-test.js » ('j') | LayoutTests/resources/js-test.js » ('J')