Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Issue 2202023007: Fuchsia Fix FindCodeObject test. (Closed)

Created:
4 years, 4 months ago by zra
Modified:
4 years, 4 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fuchsia Fix FindCodeObject test. It can't handle having the large array on the stack. R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/081718c198648d621d5ade27b9a06badc30cf0d6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -8 lines) Patch
M runtime/vm/find_code_object_test.cc View 1 chunk +9 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
zra
4 years, 4 months ago (2016-08-02 19:20:42 UTC) #2
siva
lgtm
4 years, 4 months ago (2016-08-02 19:57:01 UTC) #3
zra
4 years, 4 months ago (2016-08-02 20:10:50 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
081718c198648d621d5ade27b9a06badc30cf0d6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698