Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(758)

Issue 2201983002: gn: Update clang_version when using ToT Clang (Closed)

Created:
4 years, 4 months ago by hans
Modified:
4 years, 4 months ago
Reviewers:
Nico
CC:
chromium-reviews, etienneb
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gn: Update clang_version when using ToT Clang Tip-of-tree Clang is now at 4.0.0. BUG=none Committed: https://crrev.com/30c4ca0b7409fe9dcd2d399fbb30a5e0c1fc76ee Cr-Commit-Position: refs/heads/master@{#409080}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -12 lines) Patch
M build/config/compiler/BUILD.gn View 1 chunk +0 lines, -8 lines 0 comments Download
M build/toolchain/toolchain.gni View 2 chunks +18 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
hans
Please take a look. Ideally we'd like to shell out to "update.py --print-clang-version" for this, ...
4 years, 4 months ago (2016-08-01 21:28:09 UTC) #2
Nico
lgtm
4 years, 4 months ago (2016-08-01 21:30:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2201983002/1
4 years, 4 months ago (2016-08-01 21:32:14 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-01 22:39:35 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-01 22:41:18 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/30c4ca0b7409fe9dcd2d399fbb30a5e0c1fc76ee
Cr-Commit-Position: refs/heads/master@{#409080}

Powered by Google App Engine
This is Rietveld 408576698